Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1260953002: [arm] Fix --enable-vldr-imm. (Closed)

Created:
5 years, 4 months ago by jbramley
Modified:
5 years, 4 months ago
Reviewers:
Benedikt Meurer, ulan, Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm] Fix --enable-vldr-imm. This fixes several bugs related to float64 pool constants. Note that float64 pool constants are still disabled by default, and are only used if --enable-vldr-imm is provided. BUG= Committed: https://crrev.com/def86473440908ca93795bb3af515a721f4583cf Cr-Commit-Position: refs/heads/master@{#29917}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -23 lines) Patch
M src/arm/assembler-arm.cc View 8 chunks +32 lines, -23 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
jbramley
5 years, 4 months ago (2015-07-28 09:51:49 UTC) #2
Benedikt Meurer
LGTM from my side.
5 years, 4 months ago (2015-07-28 10:41:57 UTC) #3
ulan
lgtm
5 years, 4 months ago (2015-07-28 10:56:58 UTC) #4
Yang
On 2015/07/28 10:56:58, ulan wrote: > lgtm lgtm.
5 years, 4 months ago (2015-07-28 10:58:42 UTC) #5
Yang
On 2015/07/28 10:56:58, ulan wrote: > lgtm lgtm.
5 years, 4 months ago (2015-07-28 10:58:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1260953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1260953002/1
5 years, 4 months ago (2015-07-28 10:59:52 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-30 09:11:15 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 09:11:39 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/def86473440908ca93795bb3af515a721f4583cf
Cr-Commit-Position: refs/heads/master@{#29917}

Powered by Google App Engine
This is Rietveld 408576698