Enable MJPEG HW decode accelerator on Intel CrOS platforms

Enable MJPEG HW decode accelerator on Intel CrOS platforms

Following are the performance numbers for apprtc.appspot.com test
(no loopback) on Peppy.

With cpu governer = performance,
               SW     HW
latency(ms)    7.3    5.2
total CPU(%)  21.6   12.9
power (mWh/s)  2.2    2.2

With default cpu governer = ondemand,
               SW     HW
latency(ms)   10.3    5.5
total CPU(%)  27.4   22.1
power (mWh/s)  2.22   2.21

BUG=426381
TEST=test apprtc on squawks.

Committed: https://crrev.com/b5ab150809ca86515cf4fa3fedd2696f71dfb51f
Cr-Commit-Position: refs/heads/master@{#341072}

[henryhsu, 2015-07-28 08:01:59]

henryhsu@chromium.org changed reviewers:
+ kcwu@chromium.org, posciak@chromium.org, wuchengli@chromium.org

[henryhsu, 2015-07-28 08:02:00]

PTAL

[kcwu, 2015-07-28 08:11:07]

lgtm

nits

https://codereview.chromium.org/1260923002/diff/1/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/1260923002/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:7016: +        <message
name="IDS_FLAGS_DISABLE_ACCELERATED_MJPEG_DECODE_NAME" desc="Name of the flag to
disable accelerated mjpeg decode for captured frame where available.">
No need to say "where available" for disable.

https://codereview.chromium.org/1260923002/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:7020: +          Disable hardware-accelerated
mjpeg decode for captured frame where available.
ditto.

[wuchengli, 2015-07-28 08:16:55]

lgtm

https://codereview.chromium.org/1260923002/diff/1/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/1260923002/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:7016: +        <message
name="IDS_FLAGS_DISABLE_ACCELERATED_MJPEG_DECODE_NAME" desc="Name of the flag to
disable accelerated mjpeg decode for captured frame where available.">
On 2015/07/28 08:11:07, kcwu wrote:
> No need to say "where available" for disable.
This message follows the message of video flag. I think it still makes sense
because if accelerated decode is not available, disable flag has no effect.
Either is fine with me.

[henryhsu, 2015-07-28 09:05:28]

henryhsu@chromium.org changed reviewers:
+ asvitkine@chromium.org, piman@chromium.org

[henryhsu, 2015-07-28 09:05:29]

asvitkine@chromium.org: Please review changes in histogram

piman@chromium.org: Please review changes

Thanks.

[Alexei Svitkine (slow), 2015-07-28 14:42:20]

lgtm % comment

https://codereview.chromium.org/1260923002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/1260923002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:61186: -  <int value="-964676765"
label="enable-accelerated-mjpeg-decode"/>
Nit: Keep this value, so that data from older versions can still be decoded.

[piman, 2015-07-28 14:55:26]

lgtm

[henryhsu, 2015-07-29 06:19:39]

https://codereview.chromium.org/1260923002/diff/1/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/1260923002/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:7016: +        <message
name="IDS_FLAGS_DISABLE_ACCELERATED_MJPEG_DECODE_NAME" desc="Name of the flag to
disable accelerated mjpeg decode for captured frame where available.">
On 2015/07/28 08:16:54, wuchengli wrote:
> On 2015/07/28 08:11:07, kcwu wrote:
> > No need to say "where available" for disable.
> This message follows the message of video flag. I think it still makes sense
> because if accelerated decode is not available, disable flag has no effect.
> Either is fine with me.

I prefer to keep this then it is consistent with video decode.

https://codereview.chromium.org/1260923002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/1260923002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:61186: -  <int value="-964676765"
label="enable-accelerated-mjpeg-decode"/>
On 2015/07/28 14:42:20, Alexei Svitkine wrote:
> Nit: Keep this value, so that data from older versions can still be decoded.

Done.

[henryhsu, 2015-07-30 02:54:30]

The CQ bit was checked by henryhsu@chromium.org

[henryhsu, 2015-07-30 02:54:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
wuchengli@chromium.org, kcwu@chromium.org, asvitkine@chromium.org,
piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1260923002/#ps20001
(title: "fix nits")

[commit-bot: I haz the power, 2015-07-30 02:54:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1260923002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1260923002/20001

[commit-bot: I haz the power, 2015-07-30 07:23:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-07-30 07:23:53]

Patchset 2 (id:??) landed as
https://crrev.com/b5ab150809ca86515cf4fa3fedd2696f71dfb51f
Cr-Commit-Position: refs/heads/master@{#341072}