Change all File APIs to make the mode and encoding arguments named

sdk/lib/io/file_impl.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart.io;
 
 
 class _FileStream extends Stream<List<int>> {
   // Stream controller.
   StreamController<List<int>> _controller;
@@ skipping 86 matching lines @@
           _controller.addError(e);
           _closeFile().then((_) { _controller.close(); });
           _unsubscribed = true;
         }
       });
   }
 
   void _start() {
     Future<RandomAccessFile> openFuture;
     if (_path != null) {
-      openFuture = new File(_path).open(FileMode.READ);
+      openFuture = new File(_path).open(mode: FileMode.READ);
     } else {
       openFuture = new Future.immediate(_File._openStdioSync(0));
     }
     openFuture
       .then((RandomAccessFile opened) {
         _openedFile = opened;
         _readBlock();
       })
       .catchError((e) {
         _controller.addError(e);
@@ skipping 28 matching lines @@
     }
   }
 }
 
 class _FileStreamConsumer extends StreamConsumer<List<int>, File> {
   File _file;
   Future<RandomAccessFile> _openFuture;
   StreamSubscription _subscription;
 
   _FileStreamConsumer(File this._file, FileMode mode) {
-    _openFuture = _file.open(mode);
+    _openFuture = _file.open(mode: mode);
   }
 
   _FileStreamConsumer.fromStdio(int fd) {
     assert(1 <= fd && fd <= 2);
     _openFuture = new Future.immediate(_File._openStdioSync(fd));
   }
 
   Future<File> consume(Stream<List<int>> stream) {
     Completer<File> completer = new Completer<File>();
     _openFuture
@@ skipping 173 matching lines @@
   }
 
   external static _directory(String path);
 
   Directory directorySync() {
     var result = _directory(path);
     throwIfError(result, "Cannot retrieve directory for file '$_path'");
     return new Directory(result);
   }
 
-  Future<RandomAccessFile> open([FileMode mode = FileMode.READ]) {
+  Future<RandomAccessFile> open({FileMode mode: FileMode.READ}) {
     _ensureFileService();
     Completer<RandomAccessFile> completer = new Completer<RandomAccessFile>();
     if (mode != FileMode.READ &&
         mode != FileMode.WRITE &&
         mode != FileMode.APPEND) {
       Timer.run(() {
         completer.completeError(new ArgumentError());
       });
       return completer.future;
     }
@@ skipping 51 matching lines @@
   external static _lastModified(String path);
 
   DateTime lastModifiedSync() {
     var ms = _lastModified(path);
     throwIfError(ms, "Cannot retrieve modification time for file '$_path'");
     return new DateTime.fromMillisecondsSinceEpoch(ms);
   }
 
   external static _open(String path, int mode);
 
-  RandomAccessFile openSync([FileMode mode = FileMode.READ]) {
+  RandomAccessFile openSync({FileMode mode: FileMode.READ}) {
     if (mode != FileMode.READ &&
         mode != FileMode.WRITE &&
         mode != FileMode.APPEND) {
       throw new FileIOException("Unknown file mode. Use FileMode.READ, "
                                 "FileMode.WRITE or FileMode.APPEND.");
     }
     var id = _open(_path, mode._mode);
     throwIfError(id, "Cannot open file '$_path'");
     return new _RandomAccessFile(id, _path);
   }
@@ skipping 69 matching lines @@
     var length = opened.lengthSync();
     var result = new Uint8List(length);
     var read = opened.readListSync(result, 0, length);
     if (read != length) {
       throw new FileIOException("Failed to read file");
     }
     opened.closeSync();
     return result;
   }
 
-  Future<String> readAsString([Encoding encoding = Encoding.UTF_8]) {
+  Future<String> readAsString({Encoding encoding: Encoding.UTF_8}) {
     _ensureFileService();
     return readAsBytes().then((bytes) {
       return _decodeString(bytes, encoding);
     });
   }
 
-  String readAsStringSync([Encoding encoding = Encoding.UTF_8]) {
+  String readAsStringSync({Encoding encoding: Encoding.UTF_8}) {
     List<int> bytes = readAsBytesSync();
     return _decodeString(bytes, encoding);
   }
 
   static List<String> _decodeLines(List<int> bytes, Encoding encoding) {
     if (bytes.length == 0) return [];
     var list = [];
     var controller = new StreamController();
     controller.stream
         .transform(new StringDecoder(encoding))
         .transform(new LineTransformer())
         .listen((line) => list.add(line));
     controller.add(bytes);
     controller.close();
     return list;
   }
 
-  Future<List<String>> readAsLines([Encoding encoding = Encoding.UTF_8]) {
+  Future<List<String>> readAsLines({Encoding encoding: Encoding.UTF_8}) {
     _ensureFileService();
     Completer<List<String>> completer = new Completer<List<String>>();
     return readAsBytes().then((bytes) {
       return _decodeLines(bytes, encoding);
     });
   }
 
-  List<String> readAsLinesSync([Encoding encoding = Encoding.UTF_8]) {
+  List<String> readAsLinesSync({Encoding encoding: Encoding.UTF_8}) {
     return _decodeLines(readAsBytesSync(), encoding);
   }
 
   Future<File> writeAsBytes(List<int> bytes,
-                            [FileMode mode = FileMode.WRITE]) {
+                            {FileMode mode: FileMode.WRITE}) {
     try {
       IOSink<File> sink = openWrite(mode: mode);
       sink.writeBytes(bytes);
       sink.close();
       return sink.done.then((_) => this);;
     } catch (e) {
       return new Future.immediateError(e);
     }
   }
 
-  void writeAsBytesSync(List<int> bytes, [FileMode mode = FileMode.WRITE]) {
-    RandomAccessFile opened = openSync(mode);
+  void writeAsBytesSync(List<int> bytes, {FileMode mode: FileMode.WRITE}) {
+    RandomAccessFile opened = openSync(mode: mode);
     opened.writeListSync(bytes, 0, bytes.length);
     opened.closeSync();
   }
 
   Future<File> writeAsString(String contents,
                              {FileMode mode: FileMode.WRITE,
                               Encoding encoding: Encoding.UTF_8}) {
     try {
-      return writeAsBytes(_encodeString(contents, encoding), mode);
+      return writeAsBytes(_encodeString(contents, encoding), mode: mode);
     } catch (e) {
       var completer = new Completer();
       Timer.run(() => completer.completeError(e));
       return completer.future;
     }
   }
 
   void writeAsStringSync(String contents,
                          {FileMode mode: FileMode.WRITE,
                           Encoding encoding: Encoding.UTF_8}) {
-    writeAsBytesSync(_encodeString(contents, encoding), mode);
+    writeAsBytesSync(_encodeString(contents, encoding), mode: mode);
   }
 
   String get path => _path;
 
   String toString() => "File: '$path'";
 
   void _ensureFileService() {
     if (_fileService == null) {
       _fileService = _FileUtils._newServicePort();
     }
@@ skipping 263 matching lines @@
         _ensureFastAndSerializableBuffer(buffer, offset, bytes);
     var result =
       _writeList(_id, bufferAndOffset.buffer, bufferAndOffset.offset, bytes);
     if (result is OSError) {
       throw new FileIOException("writeList failed for file '$_path'", result);
     }
     return result;
   }
 
   Future<RandomAccessFile> writeString(String string,
-                                       [Encoding encoding = Encoding.UTF_8]) {
+                                       {Encoding encoding: Encoding.UTF_8}) {
     if (encoding is! Encoding) {
       var completer = new Completer();
       Timer.run(() {
         completer.completeError(new FileIOException(
             "Invalid encoding in writeString: $encoding"));
       });
       return completer.future;
     }
     var data = _encodeString(string, encoding);
     return writeList(data, 0, data.length);
   }
 
-  int writeStringSync(String string, [Encoding encoding = Encoding.UTF_8]) {
+  int writeStringSync(String string, {Encoding encoding: Encoding.UTF_8}) {
     if (encoding is! Encoding) {
       throw new FileIOException(
           "Invalid encoding in writeStringSync: $encoding");
     }
     var data = _encodeString(string, encoding);
     return writeListSync(data, 0, data.length);
   }
 
   Future<int> position() {
     _ensureFileService();
@@ skipping 151 matching lines @@
           new FileIOException("File closed '$_path'"));
     });
     return completer.future;
   }
 
   final String _path;
   int _id;
 
   SendPort _fileService;
 }