Issue 12609: Add a NULL channel check in CreateNPVariantParam as it can be called with...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12609: Add a NULL channel check in CreateNPVariantParam as it can be called with... (Closed)

Created:
12 years, 1 month ago by ananta

Modified:
9 years, 6 months ago

Reviewers:
jam

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add a NULL channel check in CreateNPVariantParam as it can be called with a NULL channel during renderer plugin shutdown. Fixes bug http://code.google.com/p/chromium/issues/detail?id=4740 R=jam Bug=4740 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=5943

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -9 lines)			Patch
	M	chrome/plugin/npobject_util.cc	View	1 2 3	1 chunk	+15 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jam

12 years, 1 month ago (2008-11-24 21:37:19 UTC) #2

lgtm

http://codereview.chromium.org/12609/diff/202/4
File chrome/plugin/npobject_util.cc (right):

http://codereview.chromium.org/12609/diff/202/4#newcode174
Line 174: if (channel) {
a small comment here explaining that this could happen if there was a channel
error, and the caller code's Send will fail anyways would be helpful

http://codereview.chromium.org/12609/diff/202/4#newcode175
Line 175: // NPObjectStub adds its own reference to the NPObject it owns, so if
we
nit: 80 char

Expand Messages | Collapse Messages