Issue 126083002: Pepper: Remove BrowserPpapiHostImpl::in_process().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 126083002: Pepper: Remove BrowserPpapiHostImpl::in_process(). (Closed)

Created:
6 years, 11 months ago by teravest

Modified:
6 years, 11 months ago

Reviewers:
yzshen1

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Pepper: Remove BrowserPpapiHostImpl::in_process(). It's not necessary to have this method. BUG=313943 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243746

Patch Set 1 #

Patch Set 2 : Fix CHECK condition #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -8 lines)			Patch
M	content/browser/renderer_host/pepper/browser_ppapi_host_impl.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	content/browser/renderer_host/pepper/browser_ppapi_host_impl.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/renderer_host/pepper/pepper_file_io_host.cc	View		1 chunk	+4 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

teravest

I had sent a similar change long ago, but it got lost in reverting and ...

6 years, 11 months ago (2014-01-07 16:33:01 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/126083002/70001

6 years, 11 months ago (2014-01-07 17:36:23 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) nacl_integration, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=242563

6 years, 11 months ago (2014-01-07 19:09:44 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/126083002/70001

6 years, 11 months ago (2014-01-08 21:15:39 UTC) #5

Message was sent while issue was closed.

Change committed as 243746

Expand Messages | Collapse Messages