Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 1260813008: [d8 Workers] Throw when calling Worker constructor without new (Closed)

Created:
5 years, 4 months ago by binji
Modified:
5 years, 4 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[d8 Workers] Throw when calling Worker constructor without new BUG=4399 R=jarin@chromium.org LOG=n Committed: https://crrev.com/890c4d9dc62ef6970d7ba73b13453375a739a416 Cr-Commit-Position: refs/heads/master@{#30016}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M src/d8.cc View 1 chunk +5 lines, -0 lines 0 comments Download
A + test/mjsunit/regress-4399.js View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
binji
5 years, 4 months ago (2015-08-04 19:57:36 UTC) #1
Jarin
lgtm
5 years, 4 months ago (2015-08-04 20:00:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1260813008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1260813008/1
5 years, 4 months ago (2015-08-04 20:37:23 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-04 20:39:16 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-04 20:40:36 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/890c4d9dc62ef6970d7ba73b13453375a739a416
Cr-Commit-Position: refs/heads/master@{#30016}

Powered by Google App Engine
This is Rietveld 408576698