Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(996)

Issue 1260803002: Use clang by default for mips builds (Closed)

Created:
5 years, 4 months ago by Sam Clegg
Modified:
5 years, 4 months ago
Reviewers:
Dirk Pranke, petarj
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use clang by default for mips builds This matches the current behavior or all the other linux builds. There seems to be single warning (from the GNU assembler) in the entire build, but this also occurs with gcc: Warning: tried to set unrecognized symbol: oddspreg TEST=GYP_DEFINES="target_arch=mipsel" GYP_CROSSCOMPILE=1 build/gyp_chromium && ninja -C out/Release Committed: https://crrev.com/960a546bb897a909abf9d31f3d503923d62bfe73 Cr-Commit-Position: refs/heads/master@{#340991}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M build/common.gypi View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 18 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1260803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1260803002/1
5 years, 4 months ago (2015-07-27 20:57:38 UTC) #2
Sam Clegg
5 years, 4 months ago (2015-07-27 22:33:34 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-07-27 23:26:24 UTC) #6
petarj
lgtm Thanks.
5 years, 4 months ago (2015-07-28 23:53:31 UTC) #7
Sam Clegg
+dpranke for build/OWNERS
5 years, 4 months ago (2015-07-29 00:14:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1260803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1260803002/1
5 years, 4 months ago (2015-07-29 00:15:19 UTC) #11
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 4 months ago (2015-07-29 00:15:23 UTC) #13
Dirk Pranke
lgtm
5 years, 4 months ago (2015-07-29 00:27:24 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1260803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1260803002/1
5 years, 4 months ago (2015-07-29 19:38:52 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-29 21:29:02 UTC) #17
commit-bot: I haz the power
5 years, 4 months ago (2015-07-29 21:30:17 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/960a546bb897a909abf9d31f3d503923d62bfe73
Cr-Commit-Position: refs/heads/master@{#340991}

Powered by Google App Engine
This is Rietveld 408576698