Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1260743006: Update appengine-pipelines before files API turndown. (Closed)

Created:
5 years, 4 months ago by ghost stip (do not use)
Modified:
5 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Update appengine-pipelines before files API turndown. BUG=502039 Committed: https://chromium.googlesource.com/infra/infra/+/1cf2c75a8f494a7a140e9816eb4a12b978173551

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -26 lines) Patch
M DEPS View 1 1 chunk +3 lines, -3 lines 0 comments Download
M appengine/chrome_infra_stats/pipeline View 1 chunk +1 line, -1 line 0 comments Download
M appengine/cr_rev/app.yaml View 1 chunk +1 line, -1 line 0 comments Download
M appengine/cr_rev/appengine_module/cr_rev/controller.py View 1 chunk +2 lines, -2 lines 0 comments Download
M appengine/cr_rev/appengine_module/cr_rev/test/controller_test.py View 1 chunk +2 lines, -2 lines 0 comments Download
M appengine/cr_rev/bulk-load-backend.yaml View 1 chunk +1 line, -1 line 0 comments Download
M appengine/cr_rev/launch-backend.yaml View 1 chunk +1 line, -1 line 0 comments Download
M appengine/cr_rev/scan-backend.yaml View 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/build-failure-analysis.yaml View 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/main.py View 1 chunk +2 lines, -1 line 0 comments Download
M appengine/findit/waterfall/detect_first_failure_pipeline.py View 1 chunk +2 lines, -1 line 0 comments Download
M appengine/findit/waterfall/extract_signal_pipeline.py View 1 chunk +2 lines, -1 line 0 comments Download
M appengine/findit/waterfall/pull_changelog_pipeline.py View 1 chunk +2 lines, -1 line 0 comments Download
M appengine/findit/waterfall/test/analyze_build_failure_pipeline_test.py View 1 chunk +2 lines, -1 line 0 comments Download
M appengine/findit/waterfall/test/build_failure_analysis_pipelines_test.py View 1 chunk +2 lines, -1 line 0 comments Download
M appengine/findit/waterfall/test/detect_first_failure_pipeline_test.py View 1 chunk +2 lines, -1 line 0 comments Download
M appengine/findit/waterfall/test/extract_deps_info_pipeline_test.py View 1 chunk +2 lines, -1 line 0 comments Download
M appengine/findit/waterfall/test/extract_signal_pipeline_test.py View 1 chunk +2 lines, -1 line 0 comments Download
M appengine/findit/waterfall/test/identify_culprit_pipeline_test.py View 1 chunk +2 lines, -1 line 0 comments Download
M appengine/findit/waterfall/test/pull_changelog_pipeline_test.py View 1 chunk +2 lines, -1 line 0 comments Download
A appengine_module/pipeline_utils/appengine_third_party_pipeline_python_src_pipeline View 1 chunk +1 line, -0 lines 0 comments Download
D appengine_module/pipeline_utils/appengine_third_party_pipeline_src_pipeline View 1 chunk +0 lines, -1 line 0 comments Download
M appengine_module/pipeline_utils/pipelines.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (6 generated)
ghost stip (do not use)
https://codereview.chromium.org/1260743006/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/1260743006/diff/1/DEPS#newcode49 DEPS:49: "@58cf59907f67db359fe626ee06b6d3ac448c9e15"), this includes a branch which has the fix ...
5 years, 4 months ago (2015-07-28 00:56:57 UTC) #2
ghost stip (do not use)
ptal!
5 years, 4 months ago (2015-07-28 00:57:06 UTC) #3
stgao
lgtm Many thanks! (It seems Findit has too many direct references to pipeline_utils.appengine_third_party_pipeline_src_pipeline. After this ...
5 years, 4 months ago (2015-07-28 01:29:55 UTC) #4
Erik Staab (Google)
lgtm
5 years, 4 months ago (2015-07-28 03:25:37 UTC) #6
agable
lgtm
5 years, 4 months ago (2015-07-28 17:40:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1260743006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1260743006/1
5 years, 4 months ago (2015-07-28 20:53:52 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: infra_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/infra_presubmit/builds/520)
5 years, 4 months ago (2015-07-28 21:19:59 UTC) #11
stgao
https://codereview.chromium.org/1260743006/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/1260743006/diff/1/DEPS#newcode48 DEPS:48: "GoogleCloudPlatform/appengine-pipelines.git", It seems that the ',' at end of ...
5 years, 4 months ago (2015-07-28 21:32:27 UTC) #12
ghost stip (do not use)
https://chromiumcodereview.appspot.com/1260743006/diff/1/DEPS File DEPS (right): https://chromiumcodereview.appspot.com/1260743006/diff/1/DEPS#newcode48 DEPS:48: "GoogleCloudPlatform/appengine-pipelines.git", On 2015/07/28 at 21:32:27, Shuotao wrote: > It ...
5 years, 4 months ago (2015-07-31 21:13:40 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1260743006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1260743006/20001
5 years, 4 months ago (2015-07-31 21:14:03 UTC) #16
commit-bot: I haz the power
5 years, 4 months ago (2015-07-31 21:18:10 UTC) #17
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/1cf2c75a8f494a7a140e9816eb4a1...

Powered by Google App Engine
This is Rietveld 408576698