Issue 126073005: GN: Autodetect Visual Studio versions

Issue 126073005: GN: Autodetect Visual Studio versions (Closed)

Created:
6 years, 11 months ago by brettw

Modified:
6 years, 11 months ago

Reviewers:
ncarter (slow), scottmg

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

GN: Autodetect Visual Studio versions This searches the local system for Visual Studio versions like GYP. It enables specifically requesting one version, as well as overriding the directory like GYP. BUG=

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : #

Total comments: 2

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+259 lines, -68 lines)			Patch
M	build/config/win/BUILD.gn	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
A	build/config/win/get_visual_studio_path.py	View	1 2	1 chunk	+175 lines, -0 lines	1 comment	Download
A	build/config/win/visual_studio_version.gni	View	1	1 chunk	+36 lines, -0 lines	0 comments	Download
M	build/gyp_chromium	View	1 2	1 chunk	+9 lines, -0 lines	1 comment	Download
M	build/toolchain/win/BUILD.gn	View	1 2	1 chunk	+9 lines, -15 lines	0 comments	Download
M	build/toolchain/win/setup_toolchain.py	View	1	4 chunks	+26 lines, -49 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

scottmg

"lgtm" https://codereview.chromium.org/126073005/diff/20001/build/config/win/get_visual_studio_path.py File build/config/win/get_visual_studio_path.py (right): https://codereview.chromium.org/126073005/diff/20001/build/config/win/get_visual_studio_path.py#newcode113 build/config/win/get_visual_studio_path.py:113: 2008(e) - Visual Studio 2008 (9) delete 2005/2008. ...

6 years, 11 months ago (2014-01-08 00:28:30 UTC) #2

ncarter (slow)

https://codereview.chromium.org/126073005/diff/150001/build/config/win/get_visual_studio_path.py File build/config/win/get_visual_studio_path.py (right): https://codereview.chromium.org/126073005/diff/150001/build/config/win/get_visual_studio_path.py#newcode172 build/config/win/get_visual_studio_path.py:172: sys.exit(1); I'm seeing this fail on my machine -- ...

6 years, 11 months ago (2014-01-09 00:47:21 UTC) #3

scottmg

On 2014/01/09 00:47:21, ncarter wrote: > https://codereview.chromium.org/126073005/diff/150001/build/config/win/get_visual_studio_path.py > File build/config/win/get_visual_studio_path.py (right): > > https://codereview.chromium.org/126073005/diff/150001/build/config/win/get_visual_studio_path.py#newcode172 > ...

6 years, 11 months ago (2014-01-09 00:50:27 UTC) #4

ncarter (slow)

6 years, 11 months ago (2014-01-09 00:57:18 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/126073005/diff/150001/build/gyp_chromium
File build/gyp_chromium (right):

https://codereview.chromium.org/126073005/diff/150001/build/gyp_chromium#newc...
build/gyp_chromium:186: gn_args += ' visual_studio_override_path=' + \
I think this just needs to be visual_studio_path (drop the "_override") That
fixes things for me locally. I'll upload the fix.

Expand Messages | Collapse Messages