Issue 12607013: Add MSAA configs to bench.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12607013: Add MSAA configs to bench. (Closed)

Created:
7 years, 9 months ago by bsalomon

Modified:
7 years, 9 months ago

Reviewers:
robertphillips, robertphllips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Add MSAA configs to bench. Committed: https://code.google.com/p/skia/source/detail?r=8217

Patch Set 2 : #

Total comments: 2

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+97 lines, -50 lines)			Patch
M	bench/benchmain.cpp	View	1	11 chunks	+59 lines, -19 lines	0 comments	Download
M	include/gpu/GrContext.h	View		2 chunks	+12 lines, -6 lines	0 comments	Download
M	src/gpu/GrContext.cpp	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/gpu/GrDrawTarget.h	View		2 chunks	+4 lines, -0 lines	2 comments	Download
M	src/gpu/gl/GrGLCaps.h	View	1	2 chunks	+0 lines, -6 lines	0 comments	Download
M	src/gpu/gl/GrGLCaps.cpp	View	1	3 chunks	+1 line, -7 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL.cpp	View		5 chunks	+17 lines, -12 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

bsalomon

The configs won't run if the sample count exceeds the max. And they aren't run ...

7 years, 9 months ago (2013-03-15 16:44:14 UTC) #1

robertphillips

lgtm + 1 nit https://codereview.chromium.org/12607013/diff/5001/src/gpu/GrDrawTarget.h File src/gpu/GrDrawTarget.h (right): https://codereview.chromium.org/12607013/diff/5001/src/gpu/GrDrawTarget.h#newcode50 src/gpu/GrDrawTarget.h:50: int fMaxTextureSize; extra ;

7 years, 9 months ago (2013-03-15 17:49:17 UTC) #2

bsalomon

Committed patchset #2 manually as r8217 (presubmit successful).

7 years, 9 months ago (2013-03-19 13:59:09 UTC) #3

bsalomon

7 years, 9 months ago (2013-03-19 14:02:12 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/12607013/diff/5001/src/gpu/GrDrawTarget.h
File src/gpu/GrDrawTarget.h (right):

https://codereview.chromium.org/12607013/diff/5001/src/gpu/GrDrawTarget.h#new...
src/gpu/GrDrawTarget.h:50: int fMaxTextureSize;
On 2013/03/15 17:49:17, robertphillips wrote:
> extra ;

Done.

Expand Messages | Collapse Messages

Issue 12607013: Add MSAA configs to bench. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages