chrome/browser/extensions/api/downloads/downloads_api.cc - Issue 12607011: Fix a crashing call to GURL::spec() in downloads_api.cc:DownloadItemToJSON()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/downloads/downloads_api.cc

Issue 12607011: Fix a crashing call to GURL::spec() in downloads_api.cc:DownloadItemToJSON() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: @r188114 Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/downloads/downloads_api.cc

diff --git a/chrome/browser/extensions/api/downloads/downloads_api.cc b/chrome/browser/extensions/api/downloads/downloads_api.cc

index 60831b9513a2d3dcc94bf9957d9bb7aaa3073306..fcf5d1b3336e78dcd5382e8f39d1ce63a7a21ec8 100644

--- a/chrome/browser/extensions/api/downloads/downloads_api.cc

+++ b/chrome/browser/extensions/api/downloads/downloads_api.cc

@@ -217,7 +217,8 @@ scoped_ptr<base::DictionaryValue> DownloadItemToJSON(

base::DictionaryValue* json = new base::DictionaryValue();

json->SetBoolean(kExistsKey, !download_item->GetFileExternallyRemoved());

json->SetInteger(kIdKey, download_item->GetId());

- json->SetString(kUrlKey, download_item->GetOriginalUrl().spec());

+ const GURL& url = download_item->GetOriginalUrl();

+ json->SetString(kUrlKey, (url.is_valid() ? url.spec() : ""));

json->SetString(

kFilenameKey, download_item->GetFullPath().LossyDisplayName());

json->SetString(kDangerKey, DangerString(download_item->GetDangerType()));

« no previous file with comments | « no previous file | content/browser/download/download_item_impl.cc » ('j') | no next file with comments »