Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 12607003: Added pretenuring of array literals test. (Closed)

Created:
7 years, 9 months ago by Hannes Payer (out of office)
Modified:
7 years, 9 months ago
CC:
v8-dev
Visibility:
Public.

Description

Added pretenuring of array literals test. BUG= Committed: https://code.google.com/p/v8/source/detail?r=13860

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -4 lines) Patch
M src/heap.h View 1 chunk +6 lines, -2 lines 0 comments Download
M src/heap-inl.h View 2 chunks +12 lines, -2 lines 0 comments Download
M test/cctest/test-heap.cc View 1 1 chunk +59 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Hannes Payer (out of office)
https://codereview.chromium.org/12607003/diff/1/src/heap-inl.h File src/heap-inl.h (right): https://codereview.chromium.org/12607003/diff/1/src/heap-inl.h#newcode324 src/heap-inl.h:324: return new_space_.Contains(address); Coding style fix.
7 years, 9 months ago (2013-03-07 12:27:42 UTC) #1
mvstanton
lgtm
7 years, 9 months ago (2013-03-07 13:12:24 UTC) #2
Hannes Payer (out of office)
7 years, 9 months ago (2013-03-07 14:00:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r13860 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698