src/codec/SkCodec_libbmp.cpp - Issue 1260673002: SkScaledCodec class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/codec/SkCodec_libbmp.cpp

Issue 1260673002: SkScaledCodec class (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: add helper functions to calculate sampleSize and scaledDimensions Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/codec/SkCodec_libbmp.cpp

diff --git a/src/codec/SkCodec_libbmp.cpp b/src/codec/SkCodec_libbmp.cpp

index bd5d2ca7c557fa7c4157428b8e5201cde2320254..435f864ce92de961be4ccf56748974d8a5dc553a 100644

--- a/src/codec/SkCodec_libbmp.cpp

+++ b/src/codec/SkCodec_libbmp.cpp

@@ -1134,7 +1134,7 @@ SkCodec::Result SkBmpCodec::decode(const SkImageInfo& dstInfo,

// Create swizzler

SkAutoTDelete<SkSwizzler> swizzler(SkSwizzler::CreateSwizzler(config,

- colorPtr, dstInfo, dst, dstRowBytes, kNo_ZeroInitialized));

+ colorPtr, dstInfo, dst, dstRowBytes, opts.fZeroInitialized, this->getInfo()));

// Allocate space for a row buffer and a source for the swizzler

SkAutoTDeleteArray<uint8_t> srcBuffer(SkNEW_ARRAY(uint8_t, rowBytes));