SkScaledCodec class

include/codec/SkScanlineDecoder.h

 /*
  * Copyright 2015 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef SkScanlineDecoder_DEFINED
 #define SkScanlineDecoder_DEFINED
 
@@ skipping 57 matching lines @@
      *  of the encoded data, but then never use any colors which have alpha
      *  less than 100%. This function can be called *after* decoding to
      *  determine if such an image truly had alpha. Calling it before decoding
      *  is undefined.
      *  FIXME: see skbug.com/3582.
      */
     bool reallyHasAlpha() const {
         return this->onReallyHasAlpha();
     }
 
+    /**
+     * Returns whether the image is interlaced

[scroggo, 2015/07/30 17:53:01]

These comments should match the name of the function.

+     * For an interlaced image, calling getScanlines once (regardless of the count
+     * used) needs to read the entire image, therefore it is inefficient to call
+     * getScanlines more than once. Instead, it should only ever be called with all the
+     * rows needed.

[msarett, 2015/07/30 13:55:38]

I think this comment (and the one with onIsHardToSample) could changed a little
bit to reflect the new name.  I still think it's good to mention interlaced pngs
as an example.

[emmaleer, 2015/07/30 17:50:39]

Acknowledged.

+     */
+    bool isHardToSample() {
+        return this->onIsHardToSample();
+    }
+
 protected:
     SkScanlineDecoder(const SkImageInfo& requested)
         : fDstInfo(requested)
         , fCurrScanline(0) {}
 
     virtual bool onReallyHasAlpha() const { return false; }
 
+    /**
+     * returns true if the image type is hard to sample and must be scaled after reading, not during
+     * An example is interlaced pngs, where the entire image must be read for each decode
+     */
+    virtual bool onIsHardToSample() { return false; }
+
     const SkImageInfo& dstInfo() const { return fDstInfo; }
 
 private:
     const SkImageInfo   fDstInfo;
     int                 fCurrScanline;
 
     // Naive default version just calls onGetScanlines on temp memory.
     virtual SkCodec::Result onSkipScanlines(int countLines) {
         SkAutoMalloc storage(fDstInfo.minRowBytes());
         // Note that we pass 0 to rowBytes so we continue to use the same memory.
         // Also note that while getScanlines checks that rowBytes is big enough,
         // onGetScanlines bypasses that check.
         // Calling the virtual method also means we do not double count
         // countLines.
         return this->onGetScanlines(storage.get(), countLines, 0);
     }
 
     virtual SkCodec::Result onGetScanlines(void* dst, int countLines,
                                                     size_t rowBytes) = 0;
 
 };
 #endif // SkScanlineDecoder_DEFINED