SkScaledCodec class

dm/DM.cpp

 /*
  * Copyright 2013 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "CrashHandler.h"
 #include "DMJsonWriter.h"
 #include "DMSrcSink.h"
@@ skipping 194 matching lines @@
     SkAutoTDelete<SkCodec> codec(SkCodec::NewFromData(encoded));
     if (NULL == codec.get()) {
         SkDebugf("Couldn't create codec for %s.", path.c_str());
         return;
     }
 
     // Choose scales for scaling tests.
     // TODO (msarett): Add more scaling tests as we implement more flexible scaling.
     // TODO (msarett): Implement scaling tests for SkImageDecoder in order to compare with these
     //                 tests.  SkImageDecoder supports downscales by integer factors.
-    const float scales[] = { 0.125f, 0.25f, 0.375f, 0.5f, 0.625f, 0.750f, 0.875f, 1.0f };
+    // SkJpegCodec natively supports scaling to: 0.125, 0.25, 0.375, 0.5, 0.625, 0.75, 0.875
+    // We test natively supported scales and non natively supported scales, to test all functionalty

[scroggo, 2015/08/05 15:36:00]

Do we need all of these before we start supporting partial native scales?

[emmaleer, 2015/08/05 18:41:51]

I removed an couple, but I think we need most of them.

+    const float scales[] = { 0.1f, 0.125f, 0.16666666f, 0.2f, 0.25f, 0.3f, 0.375f, 0.4f, 0.5f, 0.6f,
+                             0.625f, 0.7f, 0.750f, 0.8f, 0.875f, 0.9f, 1.0f };

[msarett, 2015/08/05 15:54:56]

Per our discussion in person, let's try to make it a little clearer what the
scales are intended to test and maybe remove a few?

// SkJpegCodec natively supports scaling to: 0.125, 0.25, 0.375, 0.5, 0.625,
0.75, 0.875
// 0.1, 0.16, 0.2 etc allow us to test SkScaledCodec with sampleSize 10, 6, 5,
etc
// 0.4, 0.7 etc allow to test what happens when the client requests a scale that
does not exactly match a sampleSize or native scaling capability

[emmaleer, 2015/08/05 18:41:52]

Acknowledged.

 
     for (float scale : scales) {
         if (scale != 1.0f && (path.endsWith(".webp") || path.endsWith(".WEBP"))) {
             // FIXME: skbug.com/4038 Scaling webp seems to leave some pixels uninitialized/
             // compute their colors based on uninitialized values.
             continue;
         }
         // Build additional test cases for images that decode natively to non-canvas types
         switch(codec->getInfo().colorType()) {
             case kGray_8_SkColorType:
@@ skipping 617 matching lines @@
     }
     return 0;
 }
 
 #if !defined(SK_BUILD_FOR_IOS)
 int main(int argc, char** argv) {
     SkCommandLineFlags::Parse(argc, argv);
     return dm_main();
 }
 #endif