Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1260663004: Add histogram for tracking the time for retrieving system accounts. (Closed)

Created:
5 years, 4 months ago by nyquist
Modified:
5 years, 4 months ago
Reviewers:
jwd
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add histogram for tracking the time for retrieving system accounts. On Android, it might be slow to retrieve the list of accounts, and as such, we should track how long time it takes to query for them, since this is done from the main thread. BUG=509826 Committed: https://crrev.com/96bb0fdb968033261cc9d5a7b4906208fef61f26 Cr-Commit-Position: refs/heads/master@{#341228}

Patch Set 1 #

Patch Set 2 : Also start using histogram upstream #

Total comments: 2

Patch Set 3 : Changed to use suffix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -1 line) Patch
M sync/android/java/src/org/chromium/sync/signin/SystemAccountManagerDelegate.java View 1 2 3 chunks +24 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
nyquist
jwd: PTAL
5 years, 4 months ago (2015-07-29 20:47:53 UTC) #2
jwd
lgtm https://codereview.chromium.org/1260663004/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1260663004/diff/20001/tools/metrics/histograms/histograms.xml#newcode39319 tools/metrics/histograms/histograms.xml:39319: +<histogram name="Signin.AndroidGetAccountsTimeInternal" units="milliseconds"> I think it's overkill here, ...
5 years, 4 months ago (2015-07-30 15:08:40 UTC) #3
nyquist
https://codereview.chromium.org/1260663004/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1260663004/diff/20001/tools/metrics/histograms/histograms.xml#newcode39319 tools/metrics/histograms/histograms.xml:39319: +<histogram name="Signin.AndroidGetAccountsTimeInternal" units="milliseconds"> On 2015/07/30 15:08:39, Jesse Doherty wrote: ...
5 years, 4 months ago (2015-07-30 22:46:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1260663004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1260663004/40001
5 years, 4 months ago (2015-07-30 22:48:04 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-07-30 23:55:32 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 23:56:07 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/96bb0fdb968033261cc9d5a7b4906208fef61f26
Cr-Commit-Position: refs/heads/master@{#341228}

Powered by Google App Engine
This is Rietveld 408576698