Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 126063004: Add flag to enable Privet storage (Closed)

Created:
6 years, 11 months ago by Noam Samuel
Modified:
6 years, 11 months ago
Visibility:
Public.

Description

Add flag to enable Privet storage Add flag to enable Privet-based storage BUG=332182 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243745

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/common/chrome_switches.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Noam Samuel
6 years, 11 months ago (2014-01-07 18:32:58 UTC) #1
Vitaly Buka (NO REVIEWS)
lgtm https://codereview.chromium.org/126063004/diff/1/chrome/common/chrome_switches.cc File chrome/common/chrome_switches.cc (right): https://codereview.chromium.org/126063004/diff/1/chrome/common/chrome_switches.cc#newcode418 chrome/common/chrome_switches.cc:418: const char kEnablePrivetStorage[] = "enable-privet-storage"; same https://codereview.chromium.org/126063004/diff/1/chrome/common/chrome_switches.h File ...
6 years, 11 months ago (2014-01-07 21:13:22 UTC) #2
Vitaly Buka (NO REVIEWS)
On 2014/01/07 18:32:58, Noam Samuel wrote: bug id?
6 years, 11 months ago (2014-01-07 21:13:41 UTC) #3
Noam Samuel
Added Bug ID https://codereview.chromium.org/126063004/diff/1/chrome/common/chrome_switches.cc File chrome/common/chrome_switches.cc (right): https://codereview.chromium.org/126063004/diff/1/chrome/common/chrome_switches.cc#newcode418 chrome/common/chrome_switches.cc:418: const char kEnablePrivetStorage[] = "enable-privet-storage"; On ...
6 years, 11 months ago (2014-01-07 21:48:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/126063004/80001
6 years, 11 months ago (2014-01-07 21:55:10 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=43613
6 years, 11 months ago (2014-01-07 22:18:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/126063004/80001
6 years, 11 months ago (2014-01-08 23:55:57 UTC) #7
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 02:17:05 UTC) #8
Message was sent while issue was closed.
Change committed as 243745

Powered by Google App Engine
This is Rietveld 408576698