Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 126063003: Fixed single quote escaping (Closed)

Created:
6 years, 11 months ago by terry
Modified:
6 years, 11 months ago
Reviewers:
midoringo, Siggi Cherem (dart-lang)
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M pkg/csslib/lib/parser.dart View 2 chunks +6 lines, -0 lines 0 comments Download
M pkg/csslib/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/csslib/test/compiler_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/csslib/test/declaration_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
terry
csslib was normalizing all declaration strings as "" - seemed like a neat idea but ...
6 years, 11 months ago (2014-01-07 18:11:03 UTC) #1
Siggi Cherem (dart-lang)
lgtm
6 years, 11 months ago (2014-01-07 20:43:19 UTC) #2
terry
6 years, 11 months ago (2014-01-07 21:32:18 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r31578 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698