Issue 1260623003: Remove duplicate mojom.dart files from mojo_services

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1260623003: Remove duplicate mojom.dart files from mojo_services (Closed)

Created:
5 years, 4 months ago by abarth-chromium

Modified:
5 years, 4 months ago

Reviewers:
Cutch

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Remove duplicate mojom.dart files from mojo_services TBR=johnmccutchan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/98c3a342288efb294f4c0d538c4331489e1c86ff

Patch Set 1 #

Patch Set 2 : Fix build #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -6 lines)			Patch
	M	mojo/dart/mojo_services/BUILD.gn	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	third_party/dart-pkg/BUILD.gn	View	1	2 chunks	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

Committed patchset #2 (id:20001) manually as 98c3a342288efb294f4c0d538c4331489e1c86ff (presubmit successful).

5 years, 4 months ago (2015-07-30 05:49:06 UTC) #2

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages