Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1260613006: Move SkTHash.h to include/private. (Closed)

Created:
5 years, 4 months ago by mtklein_C
Modified:
5 years, 4 months ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move SkTHash.h to include/private. include/views/SkOSWindow_Win.h includes it. To move SkTHash.h to include/private, SkChecksum.h needs to go there too. To move SkChecksum.h to include/private, SkTLogic needs to go there too. This adds a bunch of -Iinclude/private to tools.gyp I missed in the last CL. No public API changes. TBR=reed@google.com BUG=skia:4126 Committed: https://skia.googlesource.com/skia/+/fd8ed69447f2a126f7006a1a95356f15feca3797

Patch Set 1 #

Patch Set 2 : rabbithole #

Patch Set 3 : a bunch of missing includes #

Patch Set 4 : rm #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -602 lines) Patch
M gyp/tools.gyp View 1 2 15 chunks +15 lines, -0 lines 0 comments Download
M gyp/utils.gypi View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M include/gpu/GrBlend.h View 1 1 chunk +1 line, -1 line 0 comments Download
A + include/private/SkChecksum.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + include/private/SkTHash.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + include/private/SkTLogic.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M include/views/SkOSWindow_Win.h View 1 chunk +2 lines, -2 lines 0 comments Download
D src/core/SkChecksum.h View 1 1 chunk +0 lines, -198 lines 0 comments Download
D src/core/SkTHash.h View 1 chunk +0 lines, -292 lines 0 comments Download
D src/utils/SkTLogic.h View 1 1 chunk +0 lines, -111 lines 0 comments Download

Messages

Total messages: 23 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1260613006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1260613006/1
5 years, 4 months ago (2015-07-28 16:00:46 UTC) #2
mtklein_C
5 years, 4 months ago (2015-07-28 16:02:51 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1260613006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1260613006/20001
5 years, 4 months ago (2015-07-28 16:10:20 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/2281) Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on ...
5 years, 4 months ago (2015-07-28 16:11:03 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1260613006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1260613006/40001
5 years, 4 months ago (2015-07-28 16:13:13 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1260613006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1260613006/60001
5 years, 4 months ago (2015-07-28 16:16:05 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-07-28 16:30:04 UTC) #15
bungeman-skia
lgtm
5 years, 4 months ago (2015-07-28 16:52:47 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1260613006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1260613006/60001
5 years, 4 months ago (2015-07-28 16:52:54 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/1370)
5 years, 4 months ago (2015-07-28 16:53:35 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1260613006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1260613006/60001
5 years, 4 months ago (2015-07-28 16:54:14 UTC) #22
commit-bot: I haz the power
5 years, 4 months ago (2015-07-28 16:54:55 UTC) #23
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/fd8ed69447f2a126f7006a1a95356f15feca3797

Powered by Google App Engine
This is Rietveld 408576698