ui/android/java/res/layout/autofill_keyboard_accessory_item.xml - Issue 1260583004: Gray horizontal keyboard accessory

Side by Side Diff: ui/android/java/res/layout/autofill_keyboard_accessory_item.xml

Issue 1260583004: Gray horizontal keyboard accessory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Sort xml attributes. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ui/android/java/res/drawable/autofill_chip_inset.xml ('K') | « ui/android/java/res/drawable/autofill_chip_inset.xml ('k') | ui/android/java/res/values/colors.xml » ('j') | ui/android/java/src/org/chromium/ui/autofill/AutofillKeyboardAccessory.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
	newt (away) 2015/08/03 21:31:24 formatting nit: indent wrapped lines by 4 spaces. formatting nit: indent wrapped lines by 4 spaces. Also, put android:id on its own line. <LineaLayout xmlns... android:background=... > <TextView android:id=... ... /> please use gerrit instead 2015/08/05 00:28:07 Done. Show quoted text On 2015/08/03 21:31:24, newt wrote: > formatting nit: indent wrapped lines by 4 spaces. Also, put android:id on its > own line. > > <LineaLayout xmlns... > android:background=... > > > <TextView > android:id=... > ... /> Done.
	7 android:background="@drawable/autofill_chip_inset"

	8 android:layout_height="@dimen/keyboard_accessory_height"

	9 android:layout_width="wrap_content"

	10 android:paddingEnd="@dimen/keyboard_accessory_padding"

	11 android:paddingStart="@dimen/keyboard_accessory_padding">

	12

	13 <TextView android:id="@+id/autofill_keyboard_accessory_item_name"

	14 android:drawablePadding="@dimen/keyboard_accessory_half_padding"

	15 android:ellipsize="none"

	16 android:fadingEdgeLength="@dimen/keyboard_accessory_fading_edge_leng th"

	17 android:fontFamily="sans-serif-medium"

	18 android:gravity="center_vertical"

	19 android:layout_height="match_parent"
	newt (away) 2015/08/03 21:31:24 put layout_* attributes at the top, after android: put layout_* attributes at the top, after android:id. layout_* attributes are treated differently because they're interpreted by the parent layout rather than by the view itself. please use gerrit instead 2015/08/05 00:28:07 Done. Show quoted text On 2015/08/03 21:31:24, newt wrote: > put layout_* attributes at the top, after android:id. layout_* attributes are > treated differently because they're interpreted by the parent layout rather than > by the view itself. Done.
	20 android:layout_width="wrap_content"

	21 android:minWidth="@dimen/keyboard_accessory_chip_height"

	22 android:paddingEnd="@dimen/keyboard_accessory_half_padding"

	23 android:paddingStart="@dimen/keyboard_accessory_half_padding"

	24 android:requiresFadingEdge="horizontal"

	25 android:singleLine="true"

	26 android:textColor="#333"

	27 android:textSize="@dimen/keyboard_accessory_text_size" />

	28

	29 <TextView android:id="@+id/autofill_keyboard_accessory_item_label"

	30 android:ellipsize="none"

	31 android:fadingEdgeLength="@dimen/keyboard_accessory_fading_edge_leng th"

	32 android:gravity="center_vertical"

	33 android:layout_height="match_parent"

	34 android:layout_width="wrap_content"

	35 android:paddingEnd="@dimen/keyboard_accessory_half_padding"

	36 android:requiresFadingEdge="horizontal"

	37 android:singleLine="true"

	38 android:textColor="#646464"

	39 android:textSize="@dimen/keyboard_accessory_text_size"

	40 android:visibility="gone" />

	41

	42 </LinearLayout>

OLD	NEW