ui/android/java/res/layout/autofill_keyboard_accessory_item.xml - Issue 1260583004: Gray horizontal keyboard accessory

Side by Side Diff: ui/android/java/res/layout/autofill_keyboard_accessory_item.xml

Issue 1260583004: Gray horizontal keyboard accessory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/android/java/res/layout/main.xml ('K') | « ui/android/java/res/drawable/autofill_chip_shape.xml ('k') | ui/android/java/res/values/colors.xml » ('j') | ui/android/java/src/org/chromium/ui/autofill/AutofillKeyboardAccessory.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
	aurimas (slooooooooow) 2015/07/28 00:10:28 Is this framelayout only needed for the margin? Is this framelayout only needed for the margin? please use gerrit instead 2015/07/28 21:07:46 Yes, this is the white 8dp margin all around the t Show quoted text On 2015/07/28 00:10:28, aurimas wrote: > Is this framelayout only needed for the margin? Yes, this is the white 8dp margin all around the the gray chip. Is there a better way to achieve this?
	7 xmlns:tools="http://schemas.android.com/tools"

	8 android:layout_height="48dp"

	9 android:layout_width="wrap_content"

	10 android:orientation="vertical"

	11 android:paddingBottom="@dimen/keyboard_accessory_padding"

	12 android:paddingEnd="@dimen/keyboard_accessory_half_padding"

	13 android:paddingStart="@dimen/keyboard_accessory_half_padding"
	aurimas (slooooooooow) 2015/07/28 00:10:28 Why is half of the padding here and the other half Why is half of the padding here and the other half in the scrollview? please use gerrit instead 2015/07/28 21:07:46 This is 4dp (half padding), so that the distance b Show quoted text On 2015/07/28 00:10:28, aurimas wrote: > Why is half of the padding here and the other half in the scrollview? This is 4dp (half padding), so that the distance between chips is 8dp (half padding + half padding). There is also 4dp horizontal padding in ListView (after your suggestions). That makes the distance to the left and right edges of the screen also 8dp.
	14 android:paddingTop="@dimen/keyboard_accessory_padding">

	15

	16 <LinearLayout

	17 android:background="@drawable/autofill_chip_shape"
	aurimas (slooooooooow) 2015/07/28 00:10:28 Can we rename the drawable to simply autofill_chip Can we rename the drawable to simply autofill_chip? please use gerrit instead 2015/07/28 21:07:46 Done. Show quoted text On 2015/07/28 00:10:28, aurimas wrote: > Can we rename the drawable to simply autofill_chip? Done.
	18 android:layout_height="@dimen/keyboard_accessory_chip_height"

	19 android:layout_width="wrap_content"

	20 android:paddingEnd="@dimen/keyboard_accessory_half_padding"

	21 android:paddingStart="@dimen/keyboard_accessory_half_padding">

	22

	23 <ImageView android:id="@+id/autofill_keyboard_accessory_item_icon"

	24 android:gravity="center_vertical\|center_horizontal"

	25 android:layout_height="match_parent"

	26 android:layout_width="wrap_content"

	27 android:minWidth="@dimen/keyboard_accessory_chip_height"

	28 android:visibility="gone"

	29 tools:ignore="ContentDescription" />

	30

	31 <TextView android:id="@+id/autofill_keyboard_accessory_item_name"

	32 android:requiresFadingEdge="horizontal"

	33 android:fadingEdgeLength="@dimen/keyboard_accessory_fading_edge_ length"

	34 android:ellipsize="none"

	35 android:fontFamily="sans-serif-medium"
	aurimas (slooooooooow) 2015/07/28 00:10:28 This will not work for pre API v21. -medium was in This will not work for pre API v21. -medium was introduced with Android 5.0. I would make sure that it looks ok with pre-L devices. please use gerrit instead 2015/07/28 21:07:46 The font falls back to regular on pre-L devices. U Show quoted text On 2015/07/28 00:10:28, aurimas wrote: > This will not work for pre API v21. -medium was introduced with Android 5.0. I > would make sure that it looks ok with pre-L devices. The font falls back to regular on pre-L devices. UX is OK with a screenshot of what it looks like, but may require changes after they get their hands on actual prototype.
	36 android:gravity="center_vertical\|start"

	37 android:layout_height="match_parent"

	38 android:layout_width="wrap_content"

	39 android:paddingEnd="@dimen/keyboard_accessory_half_padding"

	40 android:paddingStart="@dimen/keyboard_accessory_half_padding"

	41 android:singleLine="true"

	42 android:textColor="#DE000000"
	aurimas (slooooooooow) 2015/07/28 00:10:28 Em, why do we need alpha for the text color? The b Em, why do we need alpha for the text color? The background never changes. We should just pick the color that looks the when same with 100% opacity. Same for text color of the label. please use gerrit instead 2015/07/28 21:07:46 Done. Show quoted text On 2015/07/28 00:10:28, aurimas wrote: > Em, why do we need alpha for the text color? The background never changes. We > should just pick the color that looks the when same with 100% opacity. > > Same for text color of the label. Done.
	43 android:textSize="@dimen/keyboard_accessory_text_size"

	44 android:visibility="gone" />

	45

	46 <TextView android:id="@+id/autofill_keyboard_accessory_item_label"

	47 android:requiresFadingEdge="horizontal"

	48 android:fadingEdgeLength="@dimen/keyboard_accessory_fading_edge_ length"

	49 android:ellipsize="none"

	50 android:fontFamily="sans-serif-regular"
	aurimas (slooooooooow) 2015/07/28 00:10:28 No need to specify this, it is the default No need to specify this, it is the default please use gerrit instead 2015/07/28 21:07:46 Done. Show quoted text On 2015/07/28 00:10:28, aurimas wrote: > No need to specify this, it is the default Done.
	51 android:gravity="center_vertical\|start"

	52 android:layout_height="match_parent"

	53 android:layout_width="wrap_content"

	54 android:paddingEnd="@dimen/keyboard_accessory_half_padding"

	55 android:singleLine="true"

	56 android:textColor="#8C000000"

	57 android:textSize="@dimen/keyboard_accessory_text_size"

	58 android:visibility="gone" />

	59

	60 </LinearLayout>

	61

	62 </FrameLayout>

OLD	NEW