Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(893)

Issue 1260523004: Revert of Add getThemeColor to Tab and add plumbing for ChromeActivites. (Closed)

Created:
5 years, 4 months ago by Fabrice (no longer in Chrome)
Modified:
5 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add getThemeColor to Tab and add plumbing for ChromeActivites. (patchset #3 id:40001 of https://codereview.chromium.org/1254423006/) Reason for revert: Speculative revert. This seems to have broken BrandColorTest.testBrandColorInterstitial BrandColorTest.testNavigatingToBrandColorAndBack BrandColorTest.testNoBrandColor on Lollipop in Document Mde. Original issue's description: > Add getThemeColor to Tab and add plumbing for ChromeActivites. > > Moves all theme color computing logic to tab. Adds the necessary > update signals to ChromeActivity and adds an onUpdate call to be > overridden by extending classes. > > The main outcome of all this is, all ChromeActivities become color change aware. Doesn't add any visual changes. Yet. > > BUG=507340 > > Committed: https://crrev.com/25d23c547cd7661fe2e679d74e4272917dae2985 > Cr-Commit-Position: refs/heads/master@{#341226} TBR=dtrainor@chromium.org,yusufo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=507340 Committed: https://crrev.com/622bf10486216f89aaa3df8cd02a3daec638a53f Cr-Commit-Position: refs/heads/master@{#341332}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -82 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java View 4 chunks +0 lines, -43 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java View 7 chunks +48 lines, -11 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java View 6 chunks +0 lines, -28 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Fabrice (no longer in Chrome)
Created Revert of Add getThemeColor to Tab and add plumbing for ChromeActivites.
5 years, 4 months ago (2015-07-31 15:13:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1260523004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1260523004/1
5 years, 4 months ago (2015-07-31 15:14:32 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-31 15:15:52 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-07-31 15:16:24 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/622bf10486216f89aaa3df8cd02a3daec638a53f
Cr-Commit-Position: refs/heads/master@{#341332}

Powered by Google App Engine
This is Rietveld 408576698