chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller_unittest.mm - Issue 12605010: Add new option to open history page to show more other devices

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller_unittest.mm

Issue 12605010: Add new option to open history page to show more other devices (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: OWNERS comments 2. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc » ('j') | chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller_unittest.mm b/chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller_unittest.mm

index 1924e9163c094661a6afb82463b66a3287ffc3ba..ae8433927cc5607a12b2a7e403d8a2fbd3428504 100644

--- a/chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller_unittest.mm

@@ -109,7 +109,7 @@ TEST_F(WrenchMenuControllerTest, RecentTabsFavIcon) {

NSString* title = l10n_util::GetNSStringWithFixup(IDS_RECENT_TABS_MENU);

NSMenu* recent_tabs_menu = [[menu itemWithTitle:title] submenu];

EXPECT_TRUE(recent_tabs_menu);

- EXPECT_EQ(4, [recent_tabs_menu numberOfItems]);

+ EXPECT_EQ(6, [recent_tabs_menu numberOfItems]);

// Send a icon changed event and verify that the icon is updated.

gfx::Image icon(ResourceBundle::GetSharedInstance().GetNativeImageNamed(

@@ -155,7 +155,7 @@ TEST_F(WrenchMenuControllerTest, RecentTabsElideTitle) {

NSString* title = l10n_util::GetNSStringWithFixup(IDS_RECENT_TABS_MENU);

NSMenu* recent_tabs_menu = [[menu itemWithTitle:title] submenu];

EXPECT_TRUE(recent_tabs_menu);

- EXPECT_EQ(5, [recent_tabs_menu numberOfItems]);

+ EXPECT_EQ(7, [recent_tabs_menu numberOfItems]);

// Index 0: restore tabs menu item.

NSString* restore_tab_label = l10n_util::FixUpWindowsStyleLabel(