Adding debug SkScalerContext which returns random mask formats

Adding debug SkScalerContext which returns random mask formats

TBR=reed@google.com
BUG=skia:

Committed: https://skia.googlesource.com/skia/+/aa2f65818dd626f87bb011c993a03015eb29db50

[joshualitt, 2015-07-24 18:00:19]

joshualitt@google.com changed reviewers:
+ bungeman@google.com, joshualitt@google.com

[joshualitt, 2015-07-24 18:00:19]

ptal

[bungeman-skia, 2015-07-24 18:31:18]

https://codereview.chromium.org/1260473004/diff/1/src/core/SkGlyph.h
File src/core/SkGlyph.h (right):

https://codereview.chromium.org/1260473004/diff/1/src/core/SkGlyph.h#newcode131
src/core/SkGlyph.h:131: friend class SkRandomScalerContext; // For getting the
id of the glyph
Can't just call getGlyphID() ?

[joshualitt, 2015-07-24 18:35:41]

feedback inc

[bungeman-skia, 2015-07-24 18:43:53]

https://codereview.chromium.org/1260473004/diff/20001/src/fonts/SkRandomScale...
File src/fonts/SkRandomScalerContext.cpp (right):

https://codereview.chromium.org/1260473004/diff/20001/src/fonts/SkRandomScale...
src/fonts/SkRandomScalerContext.cpp:148: SkASSERT(glyph.fMaskFormat == format);
Even with SkScalerContext not overriding things, this is currently false on GDI.
DW knows ahead of time if it's going to get BW, but GDI doesn't.

[joshualitt, 2015-07-27 14:54:29]

On 2015/07/24 18:43:53, bungeman1 wrote:
>
https://codereview.chromium.org/1260473004/diff/20001/src/fonts/SkRandomScale...
> File src/fonts/SkRandomScalerContext.cpp (right):
> 
>
https://codereview.chromium.org/1260473004/diff/20001/src/fonts/SkRandomScale...
> src/fonts/SkRandomScalerContext.cpp:148: SkASSERT(glyph.fMaskFormat ==
format);
> Even with SkScalerContext not overriding things, this is currently false on
GDI.
> DW knows ahead of time if it's going to get BW, but GDI doesn't.

feedbnck inc

[joshualitt, 2015-07-29 17:02:38]

On 2015/07/27 14:54:29, joshualitt wrote:
> On 2015/07/24 18:43:53, bungeman1 wrote:
> >
>
https://codereview.chromium.org/1260473004/diff/20001/src/fonts/SkRandomScale...
> > File src/fonts/SkRandomScalerContext.cpp (right):
> > 
> >
>
https://codereview.chromium.org/1260473004/diff/20001/src/fonts/SkRandomScale...
> > src/fonts/SkRandomScalerContext.cpp:148: SkASSERT(glyph.fMaskFormat ==
> format);
> > Even with SkScalerContext not overriding things, this is currently false on
> GDI.
> > DW knows ahead of time if it's going to get BW, but GDI doesn't.
> 
> feedbnck inc

added twiddling in generate image, ptal

[bungeman-skia, 2015-07-29 17:06:53]

lgtm

[joshualitt, 2015-07-29 17:07:08]

The CQ bit was checked by joshualitt@google.com

[commit-bot: I haz the power, 2015-07-29 17:07:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1260473004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1260473004/60001

[commit-bot: I haz the power, 2015-07-29 17:08:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-29 17:08:26]

Try jobs failed on following builders:
  skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[joshualitt, 2015-07-29 17:10:09]

joshualitt@google.com changed reviewers:
+ reed@google.com

[joshualitt, 2015-07-29 17:10:32]

The CQ bit was checked by joshualitt@google.com

[commit-bot: I haz the power, 2015-07-29 17:10:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1260473004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1260473004/60001

[commit-bot: I haz the power, 2015-07-29 17:15:02]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/aa2f65818dd626f87bb011c993a03015eb29db50