Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1260463002: Remove slot buffer entries in deoptimized code objects after marking. (Closed)

Created:
5 years, 5 months ago by Hannes Payer (out of office)
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove slot buffer entries in deoptimized code objects after marking. BUG=chromium:507211 LOG=n Committed: https://crrev.com/20ebc602c70f9cadc229c003fdeb4668785b6228 Cr-Commit-Position: refs/heads/master@{#29864}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -82 lines) Patch
M src/heap/mark-compact.h View 4 chunks +16 lines, -7 lines 0 comments Download
M src/heap/mark-compact.cc View 8 chunks +64 lines, -75 lines 0 comments Download
M test/cctest/test-heap.cc View 1 2 1 chunk +46 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Hannes Payer (out of office)
5 years, 5 months ago (2015-07-27 08:26:08 UTC) #2
ulan
https://codereview.chromium.org/1260463002/diff/1/src/heap/mark-compact.h File src/heap/mark-compact.h (right): https://codereview.chromium.org/1260463002/diff/1/src/heap/mark-compact.h#newcode329 src/heap/mark-compact.h:329: ObjectSlot Get(intptr_t i) { Where is it used?
5 years, 5 months ago (2015-07-27 08:35:57 UTC) #3
Hannes Payer (out of office)
https://codereview.chromium.org/1260463002/diff/1/src/heap/mark-compact.h File src/heap/mark-compact.h (right): https://codereview.chromium.org/1260463002/diff/1/src/heap/mark-compact.h#newcode329 src/heap/mark-compact.h:329: ObjectSlot Get(intptr_t i) { On 2015/07/27 08:35:57, ulan wrote: ...
5 years, 5 months ago (2015-07-27 09:21:10 UTC) #4
ulan
lgtm with comment: https://codereview.chromium.org/1260463002/diff/20001/test/cctest/test-heap.cc File test/cctest/test-heap.cc (right): https://codereview.chromium.org/1260463002/diff/20001/test/cctest/test-heap.cc#newcode6030 test/cctest/test-heap.cc:6030: DCHECK(reinterpret_cast<void*>(buffer->Get(0)) == s/DCHECK/CHECK
5 years, 5 months ago (2015-07-27 09:23:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1260463002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1260463002/40001
5 years, 5 months ago (2015-07-27 09:26:02 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-27 09:49:00 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-27 09:49:21 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/20ebc602c70f9cadc229c003fdeb4668785b6228
Cr-Commit-Position: refs/heads/master@{#29864}

Powered by Google App Engine
This is Rietveld 408576698