chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc - Issue 1260453006: ui: events: Add a class to hold common touch and stylus properties

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc

Issue 1260453006: ui: events: Add a class to hold common touch and stylus properties (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address build problems, add accessor and unit tests. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/location_bar/star_view_browsertest.cc ('k') | chrome/browser/ui/views/passwords/manage_passwords_icon_view_browsertest.cc » ('j') | ui/events/event.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc

diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc b/chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc

index 50ba5dfbd5229094023b423f653212d727c46d62..9c6aa86aa4a074928c6dc866470606735a6e9a00 100644

--- a/chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc

+++ b/chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc

@@ -327,15 +327,18 @@ IN_PROC_BROWSER_TEST_F(OmniboxViewViewsTest, CloseOmniboxPopupOnTextDrag) {

// Simulate a mouse click before dragging the mouse.

gfx::Point point(omnibox_view_views->x(), omnibox_view_views->y());

- ui::MouseEvent pressed(ui::ET_MOUSE_PRESSED, point, point,

- ui::EventTimeForNow(), ui::EF_LEFT_MOUSE_BUTTON,

- ui::EF_LEFT_MOUSE_BUTTON);

+ ui::MouseEvent pressed(

+ ui::ET_MOUSE_PRESSED, point, point, ui::EventTimeForNow(),

+ ui::EF_LEFT_MOUSE_BUTTON, ui::EF_LEFT_MOUSE_BUTTON,

+ ui::PointerEventDetails(ui::EventPointerType::POINTER_TYPE_MOUSE));

omnibox_view_views->OnMousePressed(pressed);

EXPECT_TRUE(omnibox_view->model()->popup_model()->IsOpen());

// Simulate a mouse drag of the omnibox text, and the omnibox should close.

- ui::MouseEvent dragged(ui::ET_MOUSE_DRAGGED, point, point,

- ui::EventTimeForNow(), ui::EF_LEFT_MOUSE_BUTTON, 0);

+ ui::MouseEvent dragged(

+ ui::ET_MOUSE_DRAGGED, point, point, ui::EventTimeForNow(),

+ ui::EF_LEFT_MOUSE_BUTTON, 0,

+ ui::PointerEventDetails(ui::EventPointerType::POINTER_TYPE_MOUSE));

omnibox_view_views->OnMouseDragged(dragged);

EXPECT_FALSE(omnibox_view->model()->popup_model()->IsOpen());