Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 1260423002: Revert of Reland^2 "Enable loads and stores to global vars through property cell shortcuts inst… (Closed)

Created:
5 years, 4 months ago by Jakob Kummerow
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert^3 "Enable loads and stores to global vars through property cell shortcuts installed into par… (patchset #1 id:1 of https://codereview.chromium.org/1254723004/) Reason for revert: Suspected to cause Canary crashes Original issue's description: > Reland^2 "Enable loads and stores to global vars through property cell shortcuts installed into parent script context". > > This reverts commit 362b378501ac2220655e16f49c6d1aa734e657f4. > > R=ishell@chromium.org > > Committed: https://crrev.com/440ae014e56924b52337c3747221b79283f07b81 > Cr-Commit-Position: refs/heads/master@{#29849} TBR=ishell@chromium.org,v8-mips-ports@googlegroups.com,plind44@gmail.com,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true Committed: https://crrev.com/2c16d81b256ed664c376342313558a37bbce0131 Cr-Commit-Position: refs/heads/master@{#29905}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
Jakob Kummerow
Created Revert of Reland^2 "Enable loads and stores to global vars through property cell shortcuts ...
5 years, 4 months ago (2015-07-29 09:26:49 UTC) #1
Michael Hablich
On 2015/07/29 09:26:49, Jakob wrote: > Created Revert of Reland^2 "Enable loads and stores to ...
5 years, 4 months ago (2015-07-29 09:28:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1260423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1260423002/1
5 years, 4 months ago (2015-07-29 09:29:01 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/8156)
5 years, 4 months ago (2015-07-29 09:41:05 UTC) #6
Jakob Kummerow
https://codereview.chromium.org/1268463002/ should fix those failures, let's try CQing again...
5 years, 4 months ago (2015-07-29 11:23:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1260423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1260423002/1
5 years, 4 months ago (2015-07-29 11:23:42 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-29 11:48:49 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-07-29 11:49:10 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2c16d81b256ed664c376342313558a37bbce0131
Cr-Commit-Position: refs/heads/master@{#29905}

Powered by Google App Engine
This is Rietveld 408576698