Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1260403005: Fix browser import locations in bisect-manual-test scripts (Closed)

Created:
5 years, 4 months ago by wolenetz
Modified:
5 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix browser import locations in bisect-manual-test scripts Updates the imports to reference the new locations for browser_finder and browser_options in telemetry.internal.browser. BUG=516812 TEST=manual Committed: https://crrev.com/484640e764696a186910f6174ad1b666cd8509b4 Cr-Commit-Position: refs/heads/master@{#341806}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools/bisect-manual-test.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/run-bisect-manual-test.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
wolenetz
Please take a look. Thanks!
5 years, 4 months ago (2015-08-04 20:56:34 UTC) #1
wolenetz
+nednguyen, please take a look. aiolos's alias is marked "(slow to review)". Thanks!
5 years, 4 months ago (2015-08-04 21:20:59 UTC) #3
nednguyen
lgtm
5 years, 4 months ago (2015-08-04 21:24:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1260403005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1260403005/1
5 years, 4 months ago (2015-08-04 21:26:37 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-04 21:52:22 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-04 21:56:39 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/484640e764696a186910f6174ad1b666cd8509b4
Cr-Commit-Position: refs/heads/master@{#341806}

Powered by Google App Engine
This is Rietveld 408576698