Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Side by Side Diff: components/offline_pages/offline_page_feature.cc

Issue 1260403004: Add about flag for offline page experiment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add enum entries in histograms for switches Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/offline_pages/offline_page_feature.h" 5 #include "components/offline_pages/offline_page_feature.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/command_line.h"
9 #include "base/metrics/field_trial.h" 10 #include "base/metrics/field_trial.h"
11 #include "components/offline_pages/offline_page_switches.h"
10 12
11 #if defined(OS_ANDROID) 13 #if defined(OS_ANDROID)
12 14
13 namespace offline_pages { 15 namespace offline_pages {
14 16
15 namespace { 17 namespace {
16 const char kOfflinePagesFieldTrialName[] = "OfflinePages"; 18 const char kOfflinePagesFieldTrialName[] = "OfflinePages";
17 const char kOfflinePagesFieldTrialEnabledGroupName[] = "Enabled"; 19 const char kOfflinePagesFieldTrialEnabledGroupName[] = "Enabled";
18 } // namespace 20 } // namespace
19 21
20 bool IsOfflinePagesEnabled() { 22 bool IsOfflinePagesEnabled() {
23 if (base::CommandLine::ForCurrentProcess()->HasSwitch(
24 switches::kEnableOfflinePages)) {
25 return true;
26 }
27 if (base::CommandLine::ForCurrentProcess()->HasSwitch(
28 switches::kDisableOfflinePages)) {
29 return false;
30 }
31
21 std::string group_name = 32 std::string group_name =
22 base::FieldTrialList::FindFullName(kOfflinePagesFieldTrialName); 33 base::FieldTrialList::FindFullName(kOfflinePagesFieldTrialName);
23 return group_name == kOfflinePagesFieldTrialEnabledGroupName; 34 return group_name == kOfflinePagesFieldTrialEnabledGroupName;
24 } 35 }
25 36
26 } // namespace offline_pages 37 } // namespace offline_pages
27 38
28 #endif 39 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698