Add about flag for offline page experiment

Add about flag for offline page experiment

BUG=491352
Committed: https://crrev.com/b15d06fd8af2bfd7e04d4261631f40394865bcfc
Cr-Commit-Position: refs/heads/master@{#341967}

[jianli, 2015-08-04 20:47:33]

jianli@chromium.org changed reviewers:
+ fgorski@chromium.org

[fgorski, 2015-08-04 23:28:08]

lgtm

Please update flag description as provided.

https://codereview.chromium.org/1260403004/diff/20001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/1260403004/diff/20001/chrome/app/generated_re...
chrome/app/generated_resources.grd:15886: +        If enabled, pages could be
saved for offline accessing purpose.
Enable storing pages locally for offline use. Requires Enhanced Bookmarks to be
enabled.

https://codereview.chromium.org/1260403004/diff/20001/chrome/browser/about_fl...
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/1260403004/diff/20001/chrome/browser/about_fl...
chrome/browser/about_flags.cc:2104: {"offline-pages",
Did you consider:
enable-offline-pages
or
offline-pages-experiment ?

Also, did you figure out how the default is established?

[jianli, 2015-08-04 23:39:03]

https://codereview.chromium.org/1260403004/diff/20001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/1260403004/diff/20001/chrome/app/generated_re...
chrome/app/generated_resources.grd:15886: +        If enabled, pages could be
saved for offline accessing purpose.
On 2015/08/04 23:28:07, fgorski wrote:
> Enable storing pages locally for offline use. Requires Enhanced Bookmarks to
be
> enabled.

Done.

https://codereview.chromium.org/1260403004/diff/20001/chrome/browser/about_fl...
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/1260403004/diff/20001/chrome/browser/about_fl...
chrome/browser/about_flags.cc:2104: {"offline-pages",
On 2015/08/04 23:28:07, fgorski wrote:
> Did you consider:
> enable-offline-pages
> or
> offline-pages-experiment ?
This is the internal name that is not exposed to the user. The names of switches
seen by the user are kEnableOfflinePages and kDisableOfflinePages. I think
"offline-pages" is better since it is indeed meant for 3 states. Also adding
"-experiment" seems to be unnecessary.

> 
> Also, did you figure out how the default is established?

By default, we will be using the value from field trial signal.

[jianli, 2015-08-05 00:14:42]

The CQ bit was checked by jianli@chromium.org

[jianli, 2015-08-05 00:14:42]

The patchset sent to the CQ was uploaded after l-g-t-m from fgorski@chromium.org
Link to the patchset: https://codereview.chromium.org/1260403004/#ps40001
(title: "Update strings per feedback")

[commit-bot: I haz the power, 2015-08-05 00:16:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1260403004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1260403004/40001

[commit-bot: I haz the power, 2015-08-05 00:28:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-05 00:28:51]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jianli, 2015-08-05 00:37:49]

jianli@chromium.org changed reviewers:
+ asvitkine@google.com, sky@chromium.org

[jianli, 2015-08-05 00:37:49]

sky for chrome/browser/DEPS
asvitkine for tools/metrics/histograms/histograms.xml

[Alexei Svitkine (slow), 2015-08-05 15:20:27]

asvitkine@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Alexei Svitkine (slow), 2015-08-05 15:20:27]

lgtm

[sky, 2015-08-05 17:25:27]

DEPS LGTM

[jianli, 2015-08-05 20:12:05]

The CQ bit was checked by jianli@chromium.org

[commit-bot: I haz the power, 2015-08-05 20:12:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1260403004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1260403004/40001

[commit-bot: I haz the power, 2015-08-05 20:45:23]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-08-05 20:46:23]

Patchset 3 (id:??) landed as
https://crrev.com/b15d06fd8af2bfd7e04d4261631f40394865bcfc
Cr-Commit-Position: refs/heads/master@{#341967}