Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Unified Diff: Source/core/css/MediaValuesDynamic.cpp

Issue 1260403002: Oilpan: Remove raw pointer to LocalFrame from MediaValuesDynamic (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/MediaValuesDynamic.h ('k') | Source/core/css/parser/SizesAttributeParser.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/MediaValuesDynamic.cpp
diff --git a/Source/core/css/MediaValuesDynamic.cpp b/Source/core/css/MediaValuesDynamic.cpp
index 8132f38fb45d934757cd3226d9374a5040efe1c1..a222f9d509ae9013bb620f9fcee9de96a7400856 100644
--- a/Source/core/css/MediaValuesDynamic.cpp
+++ b/Source/core/css/MediaValuesDynamic.cpp
@@ -14,16 +14,16 @@
namespace blink {
-PassRefPtr<MediaValues> MediaValuesDynamic::create(Document& document)
+PassRefPtrWillBeRawPtr<MediaValues> MediaValuesDynamic::create(Document& document)
{
return MediaValuesDynamic::create(frameFrom(document));
}
-PassRefPtr<MediaValues> MediaValuesDynamic::create(LocalFrame* frame)
+PassRefPtrWillBeRawPtr<MediaValues> MediaValuesDynamic::create(LocalFrame* frame)
{
if (!frame || !frame->view() || !frame->document() || !frame->document()->layoutView())
return MediaValuesCached::create();
- return adoptRef(new MediaValuesDynamic(frame));
+ return adoptRefWillBeNoop(new MediaValuesDynamic(frame));
}
MediaValuesDynamic::MediaValuesDynamic(LocalFrame* frame)
@@ -32,9 +32,9 @@ MediaValuesDynamic::MediaValuesDynamic(LocalFrame* frame)
ASSERT(m_frame);
}
-PassRefPtr<MediaValues> MediaValuesDynamic::copy() const
+PassRefPtrWillBeRawPtr<MediaValues> MediaValuesDynamic::copy() const
{
- return adoptRef(new MediaValuesDynamic(m_frame));
+ return adoptRefWillBeNoop(new MediaValuesDynamic(m_frame));
}
bool MediaValuesDynamic::computeLength(double value, CSSPrimitiveValue::UnitType type, int& result) const
@@ -147,4 +147,10 @@ bool MediaValuesDynamic::hasValues() const
return m_frame;
}
+DEFINE_TRACE(MediaValuesDynamic)
+{
+ visitor->trace(m_frame);
+ MediaValues::trace(visitor);
+}
+
} // namespace
« no previous file with comments | « Source/core/css/MediaValuesDynamic.h ('k') | Source/core/css/parser/SizesAttributeParser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698