Upstream Android modifications to the image encoders/decoders.

src/images/SkImageDecoder_libico.cpp

 
 /*
  * Copyright 2006 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 
 #include "SkImageDecoder.h"
 #include "SkStream.h"
 #include "SkColorPriv.h"
 #include "SkTypes.h"
 
 class SkICOImageDecoder : public SkImageDecoder {
 public:
     SkICOImageDecoder();
 
     virtual Format getFormat() const {
         return kICO_Format;
     }
 
 protected:
     virtual bool onDecode(SkStream* stream, SkBitmap* bm, Mode);
 };
 
-#if 0 // UNUSED
-SkImageDecoder* SkCreateICOImageDecoder() {
-    return new SkICOImageDecoder;
-}
-#endif
-
 /////////////////////////////////////////////////////////////////////////////////////////
 
 //read bytes starting from the begin-th index in the buffer
 //read in Intel order, and return an integer
 
 #define readByte(buffer,begin) buffer[begin]
 #define read2Bytes(buffer,begin) buffer[begin]+(buffer[begin+1]<<8)
 #define read4Bytes(buffer,begin) buffer[begin]+(buffer[begin+1]<<8)+(buffer[begin+2]<<16)+(buffer[begin+3]<<24)
 
 /////////////////////////////////////////////////////////////////////////////////////////
@@ skipping 185 matching lines @@
 
     /*int */test = w & 0x1F;   //the low 5 bits - we are rounding up to the next 32 (2^5)
     /*int */mask = -(((test >> 4) | (test >> 3) | (test >> 2) | (test >> 1) | test) & 0x1);    //either 0xFFFFFFFF or 0
     int andLineWidth = (w & 0xFFFFFFE0) + (0x20 & mask);
     //if we allow different Configs, everything is the same til here
     //change the config, and use different address getter, and place index vs color, and add the color table
     //FIXME: what is the tradeoff in size?
     //if the andbitmap (mask) is all zeroes, then we can easily do an index bitmap
     //however, with small images with large colortables, maybe it's better to still do argb_8888
 
-    bm->setConfig(SkBitmap::kARGB_8888_Config, w, h, calculateRowBytesFor8888(w, bitCount));
-
     if (SkImageDecoder::kDecodeBounds_Mode == mode) {
+        bm->setConfig(SkBitmap::kARGB_8888_Config, w, h, calculateRowBytesFor8888(w, bitCount));
         delete[] colors;
         return true;
     }
+    // No Bitmap reuse supported for this format
+    if (!bm->isNull()) {
+        return false;
+    }

[robertphillips, 2013/03/11 18:25:55]

Is this expensive enough to make duplicating the code worthwhile?

[djsollen, 2013/03/11 19:43:24]

I supposed this was to work around some android bug so I didn't want to change
the code until I could verify. I believe the issue is that they don't want to
update the bitmap and then return false because the bitmap reuse is not
supported.

On 2013/03/11 18:25:55, robertphillips wrote:

+    bm->setConfig(SkBitmap::kARGB_8888_Config, w, h, calculateRowBytesFor8888(w, bitCount));
 
     if (!this->allocPixelRef(bm, NULL))
     {
         delete[] colors;
         return false;
     }
 
     SkAutoLockPixels alp(*bm);
 
     for (int y = 0; y < h; y++)
@@ skipping 129 matching lines @@
     int reserved = read2Bytes(buf, 0);
     int type = read2Bytes(buf, 2);
     if (reserved != 0 || type != 1) {
         // This stream does not represent an ICO image.
         return NULL;
     }
     return SkNEW(SkICOImageDecoder);
 }
 
 static SkTRegistry<SkImageDecoder*, SkStream*> gReg(sk_libico_dfactory);