Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1260363007: Revert "Implement caching of filled paths in the tessellated path renderer." (Closed)

Created:
5 years, 4 months ago by mtklein_C
Modified:
5 years, 4 months ago
Reviewers:
CC:
reviews_skia.org, Stephen White
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert "Implement caching of filled paths in the tessellated path renderer." This reverts commit 468dfa72eb6694145487be17876804dfca3b7adb. This CL caused signficant GM diffs. Revert "Fix resource cache test." This reverts commit b001c41ed37d2018d38ce787b412ed741585d75d. Revert "Fix SkData leaks at GrResourceKey::setCustomData() call sites." This reverts commit c369348aa596d7be05c9ce0ca5d349e5d1903789. These CLs depend on the first one. BUG=skia: TBR=bsalomon@google.com Committed: https://skia.googlesource.com/skia/+/562a66b093c45e2788aab1572d6138eb39c6dc37

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -270 lines) Patch
M include/core/SkPathRef.h View 4 chunks +13 lines, -12 lines 0 comments Download
M include/gpu/GrResourceKey.h View 4 chunks +0 lines, -13 lines 0 comments Download
M src/core/SkPathPriv.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/core/SkPathRef.cpp View 5 chunks +10 lines, -34 lines 0 comments Download
M src/gpu/GrTessellatingPathRenderer.cpp View 11 chunks +39 lines, -116 lines 0 comments Download
M tests/PathTest.cpp View 3 chunks +0 lines, -60 lines 0 comments Download
M tests/ResourceCacheTest.cpp View 3 chunks +0 lines, -31 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1260363007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1260363007/1
5 years, 4 months ago (2015-08-04 15:21:27 UTC) #2
commit-bot: I haz the power
5 years, 4 months ago (2015-08-04 15:46:18 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/562a66b093c45e2788aab1572d6138eb39c6dc37

Powered by Google App Engine
This is Rietveld 408576698