Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Unified Diff: chrome/browser/signin/signin_manager.h

Issue 126033004: Clean up ChildProcessHost unique id generation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: mac Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/signin/signin_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/signin/signin_manager.h
diff --git a/chrome/browser/signin/signin_manager.h b/chrome/browser/signin/signin_manager.h
index 0f8c0766f057a28b5252c1c9d3645b1ebe50328c..7908af196d967aee93408cd90ceda8626ecfd670 100644
--- a/chrome/browser/signin/signin_manager.h
+++ b/chrome/browser/signin/signin_manager.h
@@ -174,13 +174,15 @@ class SigninManager : public SigninManagerBase,
static bool IsSigninAllowedOnIOThread(ProfileIOData* io_data);
// Allows the SigninManager to track the privileged signin process
- // identified by |process_id| so that we can later ask (via IsSigninProcess)
+ // identified by |host_id| so that we can later ask (via IsSigninProcess)
// if it is safe to sign the user in from the current context (see
// OneClickSigninHelper). All of this tracking state is reset once the
// renderer process terminates.
- void SetSigninProcess(int process_id);
+ //
+ // N.B. This is the id returned by RenderProcessHost::GetID().
+ void SetSigninProcess(int host_id);
void ClearSigninProcess();
- bool IsSigninProcess(int process_id) const;
+ bool IsSigninProcess(int host_id) const;
bool HasSigninProcess() const;
protected:
@@ -274,7 +276,7 @@ class SigninManager : public SigninManagerBase,
// See SetSigninProcess. Tracks the currently active signin process
// by ID, if there is one.
- int signin_process_id_;
+ int signin_host_id_;
// Callback invoked during signin after an OAuth token has been fetched
// but before signin is complete.
« no previous file with comments | « no previous file | chrome/browser/signin/signin_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698