Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 126033004: Clean up ChildProcessHost unique id generation. (Closed)

Created:
6 years, 11 months ago by Avi (use Gerrit)
Modified:
6 years, 11 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Clean up ChildProcessHost unique id generation. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243683

Patch Set 1 #

Patch Set 2 : more thorough rework #

Patch Set 3 : start from 1 #

Total comments: 3

Patch Set 4 : rename #

Patch Set 5 : mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -38 lines) Patch
M chrome/browser/signin/signin_manager.h View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/signin/signin_manager.cc View 1 2 3 4 5 chunks +14 lines, -13 lines 0 comments Download
M content/browser/dom_storage/dom_storage_namespace.cc View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
M content/common/child_process_host_impl.h View 1 2 3 4 2 chunks +2 lines, -4 lines 0 comments Download
M content/common/child_process_host_impl.cc View 1 2 3 4 4 chunks +16 lines, -11 lines 0 comments Download
M content/public/browser/render_process_host.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/common/child_process_host.h View 1 2 3 4 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Avi (use Gerrit)
WDYT about promoting this to the interface? It would be nice to get everyone on ...
6 years, 11 months ago (2014-01-07 17:43:33 UTC) #1
Avi (use Gerrit)
OK, this is a deeper reworking.
6 years, 11 months ago (2014-01-07 18:12:18 UTC) #2
jam
lgtm https://codereview.chromium.org/126033004/diff/120001/content/public/common/child_process_host.h File content/public/common/child_process_host.h (right): https://codereview.chromium.org/126033004/diff/120001/content/public/common/child_process_host.h#newcode29 content/public/common/child_process_host.h:29: static int kInvalidChildProcessUniqueId; nit: ChildProcessHost::kInvalidChildProcessUniqueId seems redundant. how ...
6 years, 11 months ago (2014-01-07 21:05:00 UTC) #3
Avi (use Gerrit)
https://codereview.chromium.org/126033004/diff/120001/content/public/common/child_process_host.h File content/public/common/child_process_host.h (right): https://codereview.chromium.org/126033004/diff/120001/content/public/common/child_process_host.h#newcode29 content/public/common/child_process_host.h:29: static int kInvalidChildProcessUniqueId; Done.
6 years, 11 months ago (2014-01-07 21:47:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/126033004/220001
6 years, 11 months ago (2014-01-07 21:54:40 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=208722
6 years, 11 months ago (2014-01-07 22:25:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/126033004/220001
6 years, 11 months ago (2014-01-08 00:11:12 UTC) #7
commit-bot: I haz the power
Retried try job too often on mac for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number=113820
6 years, 11 months ago (2014-01-08 01:55:00 UTC) #8
Avi (use Gerrit)
https://codereview.chromium.org/126033004/diff/120001/content/public/common/child_process_host.h File content/public/common/child_process_host.h (right): https://codereview.chromium.org/126033004/diff/120001/content/public/common/child_process_host.h#newcode29 content/public/common/child_process_host.h:29: static int kInvalidChildProcessUniqueId; On 2014/01/07 21:47:47, Avi wrote: > ...
6 years, 11 months ago (2014-01-08 16:25:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/126033004/550001
6 years, 11 months ago (2014-01-08 17:03:49 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=243459
6 years, 11 months ago (2014-01-08 21:01:06 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/126033004/550001
6 years, 11 months ago (2014-01-08 21:06:27 UTC) #12
commit-bot: I haz the power
6 years, 11 months ago (2014-01-08 22:55:54 UTC) #13
Message was sent while issue was closed. 
Change committed as 243683

Powered by Google App Engine
This is Rietveld 408576698