Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: Source/platform/graphics/filters/FEFlood.cpp

Issue 126033003: Support colors w/ alpha in SVG 'stop' elements and 'feFlood' (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase; Prebake expected colors. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/graphics/Color.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/graphics/filters/FEFlood.cpp
diff --git a/Source/platform/graphics/filters/FEFlood.cpp b/Source/platform/graphics/filters/FEFlood.cpp
index 92b62bc80c3a254d54d3ec2f3b79726c953c9c39..3bd7991f5423a159fd2c77ca097c589457c30f38 100644
--- a/Source/platform/graphics/filters/FEFlood.cpp
+++ b/Source/platform/graphics/filters/FEFlood.cpp
@@ -79,14 +79,14 @@ void FEFlood::applySoftware()
if (!resultImage)
return;
- Color color = colorWithOverrideAlpha(floodColor().rgb(), floodOpacity());
+ Color color = floodColor().combineWithAlpha(floodOpacity());
resultImage->context()->fillRect(FloatRect(FloatPoint(), absolutePaintRect().size()), color);
FilterEffect::setResultColorSpace(ColorSpaceDeviceRGB);
}
PassRefPtr<SkImageFilter> FEFlood::createImageFilter(SkiaImageFilterBuilder* builder)
{
- Color color = colorWithOverrideAlpha(floodColor().rgb(), floodOpacity());
+ Color color = floodColor().combineWithAlpha(floodOpacity());
SkImageFilter::CropRect rect = getCropRect(builder->cropOffset());
SkAutoTUnref<SkColorFilter> cf(SkColorFilter::CreateModeFilter(color.rgb(), SkXfermode::kSrc_Mode));
« no previous file with comments | « Source/platform/graphics/Color.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698