Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: infra_libs/ts_mon/monitors.py

Issue 1260293009: make version of ts_mon compatible with appengine (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: take out deleted utils methods Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« appengine_module/gae_ts_mon/monitors.py ('K') | « infra_libs/ts_mon/metrics.py ('k') | infra_libs/ts_mon/standard_metrics.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: infra_libs/ts_mon/monitors.py
diff --git a/infra_libs/ts_mon/monitors.py b/infra_libs/ts_mon/monitors.py
index 1956a2f728f5dc660297e9360a112c23545308c3..6fc9c55cd29faaa468f5f0b285d28b218696c7e4 100644
--- a/infra_libs/ts_mon/monitors.py
+++ b/infra_libs/ts_mon/monitors.py
@@ -43,11 +43,11 @@ from monacq.proto import metrics_pb2
from infra_libs import logs
import infra_libs
-import httplib2
from apiclient import discovery
from oauth2client.client import GoogleCredentials
from oauth2client.file import Storage
from oauth2client.gce import AppAssertionCredentials
+import httplib2
# Special string that can be passed through as the credentials path to use the
# default GCE service account.
@@ -122,7 +122,7 @@ class ApiMonitor(Monitor):
"""
try:
self._api.Send(self._wrap_proto(metric_pb))
- except acquisition_api.AcquisitionApiRequestException as e:
+ except acquisition_api.AcquisitionApiRequestException as e: # pylint: disable=undefined-variable
Sergey Berezin 2015/08/18 00:40:38 nit: any way to stay within 80 char limit? Maybe t
jshu 2015/08/18 01:15:55 don't think we actually need that comment
logging.error('Failed to send the metrics: %s', e)
« appengine_module/gae_ts_mon/monitors.py ('K') | « infra_libs/ts_mon/metrics.py ('k') | infra_libs/ts_mon/standard_metrics.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698