make version of ts_mon compatible with appengine

appengine_module/gae_ts_mon/config.py

+# Copyright 2015 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import json
+import logging
+import os
+import socket
+import sys
+import urlparse
+import re
+
+import monitors
+import interface
+from common import standard_metrics
+from common import targets
+
+
+def initialize(endpoint=None, flush='manual', job_name=None,
+               service_name=None, instance=0):
+  """Initialize the global monitor.
+
+  Also initializes the default target if endpoint argument is supplied.
+  If they aren't, all created metrics will have to supply their own target.
+  This is generally a bad idea, as many libraries rely on the default target
+  being set up.
+
+  Args:
+    endpoint: url (in format pubsub://project/topic) to post ts_mon metrics to
+    flush:  metric push behavior: all (send every metric individually),
+            or manual (only send when flush() is called)
+    job_name: name of the job instance of the task
+    instance: number of instance for this task
+    service_name: name of service being monitored
+
+  """
+  hostname = socket.getfqdn().split('.')[0]
+  try:
+    region = fqdn.split('.')[1]
+  except:
+    region = ''
+
+  if endpoint.startswith('pubsub://'):

[Sergey Berezin, 2015/08/18 00:40:37]

nit: I feel this logic should belong in ts_mon itself. It'll work now, but if we
switch to yet another future service later, we'll have to modify it in several
places.

If you plan to land it as is, please file a bug against Infra-Monitoring to fix
it later.

[jshu, 2015/08/18 01:15:55]

thanks for drawing attention this, going to take out that if statement since I
set the endpoint in gae_ts_mon myself in another file so there is no point in
checking it. the logic is in ts_mon itself, it was just duplicated here because
they don't inherit form each other. but if i understand correctly someone should
update it since we are now only using pubsub? not sure if I would be the right
person to file the bug since I don't know much about that project and it has
little to do with gae_ts_mon.

[Sergey Berezin, 2015/08/18 17:31:38]

Filed http://crbug.com/522135

The danger of duplicating code is that it becomes inconsistent with time. We are
using pubsub exclusively right now, but I don't know what will happen, say, a
year from now.

[jshu, 2015/08/20 00:23:34]

Those two files are completely different. 

+    url = urlparse.urlparse(endpoint)
+    project = url.netloc
+    topic = url.path.strip('/')
+    interface.state.global_monitor = monitors.PubSubMonitor(project, topic)
+  else:
+    logging.error('Error: endpoint should begin with pubsub://')
+    interface.state.global_monitor = monitors.NullMonitor()
+
+  # Reimplement ArgumentParser.error, since we don't have access to the parser
+  if not service_name:
+    logging.error('service_name variable is not set for task.')
+  if not job_name:  # pragma: no cover
+    logging.error('job_name variable is not set for task.')
+  interface.state.default_target = targets.TaskTarget(
+      service_name, job_name, region, hostname, instance)
+
+  interface.state.flush_mode = flush
+
+  standard_metrics.init()