infra_libs/http_metrics.py - Issue 1260293009: make version of ts_mon compatible with appengine

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: infra_libs/http_metrics.py

Issue 1260293009: make version of ts_mon compatible with appengine (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: set correct metric and target fields Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2015 The Chromium Authors. All rights reserved.	1 # Copyright 2015 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 from infra_libs.ts_mon import metrics	5 from infra_libs.ts_mon.metrics import CumulativeDistributionMetric

	6 from infra_libs.ts_mon.metrics import CounterMetric

6	7

7 request_bytes = metrics.CumulativeDistributionMetric('http/request_bytes')	8 request_bytes = CumulativeDistributionMetric('http/request_bytes')
	agable 2015/08/12 22:18:08 These all seem like great metrics to have built in These all seem like great metrics to have built in to gae_ts_mon! jshu 2015/08/14 20:47:56 good call Show quoted text On 2015/08/12 at 22:18:08, agable wrote: > These all seem like great metrics to have built in to gae_ts_mon! good call
8 response_bytes = metrics.CumulativeDistributionMetric('http/response_bytes')	9 response_bytes = CumulativeDistributionMetric('http/response_bytes')

9 durations = metrics.CumulativeDistributionMetric('http/durations')	10 durations = CumulativeDistributionMetric('http/durations')

10 response_status = metrics.CounterMetric('http/response_status')	11 response_status = CounterMetric('http/response_status')

11	12

12	13

13 def _reset_for_testing(): # pragma: no cover	14 def _reset_for_testing(): # pragma: no cover

14 for metric in (request_bytes, response_bytes, durations, response_status):	15 for metric in (request_bytes, response_bytes, durations, response_status):

15 metric.reset()	16 metric.reset()

OLD	NEW

« appengine_module/config.proto ('K') | « appengine_module/gae_ts_mon/third_party/uritemplate ('k') | infra_libs/logs/logs.py » ('j') | no next file with comments »