appengine_module/config.proto - Issue 1260293009: make version of ts_mon compatible with appengine

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: appengine_module/config.proto

Issue 1260293009: make version of ts_mon compatible with appengine (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: set correct metric and target fields Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 syntax = "proto3";	1 syntax = "proto3";
	agable 2015/08/12 22:18:08 See comment on earlier patchset: this file shouldn See comment on earlier patchset: this file shouldn't live in appengine_module. It should continue to live in infra_libs/ts_mon, and I don't think there's any reason to copy it over for gae_ts_mon. And even if there is a reason to copy it over for gae_ts_mon, then it should live in appengine_module/gae_ts_mon/ instead of here. jshu 2015/08/14 20:47:56 whoops, don't know how that got here haha Show quoted text On 2015/08/12 at 22:18:08, agable wrote: > See comment on earlier patchset: this file shouldn't live in appengine_module. It should continue to live in infra_libs/ts_mon, and I don't think there's any reason to copy it over for gae_ts_mon. And even if there is a reason to copy it over for gae_ts_mon, then it should live in appengine_module/gae_ts_mon/ instead of here. whoops, don't know how that got here haha
2	2

3 // ts_mon's config file in /etc/chrome-infra/ts-mon.json is a JSON-encoded	3 // ts_mon's config file in /etc/chrome-infra/ts-mon.json is a JSON-encoded

4 // ConfigFile message.	4 // ConfigFile message.

5 // Note: this .proto file isn't currently used to encode/decode the config file,	5 // Note: this .proto file isn't currently used to encode/decode the config file,

6 // it's just here as a reference.	6 // it's just here as a reference.

7 message ConfigFile {	7 message ConfigFile {

8 // Url to post monitoring metrics to. file:// URLs are supported as well.	8 // Url to post monitoring metrics to. file:// URLs are supported as well.

9 string endpoint = 1;	9 string endpoint = 1;

10	10

11 // Path to a pkcs8 json credential file.	11 // Path to a pkcs8 json credential file.

12 string credentials = 2;	12 string credentials = 2;

13 }	13 }

OLD	NEW

« appengine/sheriff_o_matic/utils.py ('K') | « appengine/sheriff_o_matic/utils.py ('k') | appengine_module/gae_ts_mon/__init__.py » ('j') | infra_libs/http_metrics.py » ('J')