Issue 1260293004: Revert of Move draw on upload decision in GrGpu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1260293004: Revert of Move draw on upload decision in GrGpu (Closed)

Created:
5 years, 4 months ago by bsalomon

Modified:
5 years, 4 months ago

Reviewers:
robertphillips

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of Move draw on upload decision in GrGpu (patchset #4 id:50001 of https://codereview.chromium.org/1257073003/) Reason for revert: breaking write pixels test on bots Original issue's description: > Move draw on upload decision in GrGpu > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/0341b4427e5f037e3b501ed6e57dfdb7b40f150e TBR=robertphillips@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/c3fb74693e25cf6dffc8add8669c54c4b7ace3a2

Patch Set 1 #

Created: 5 years, 4 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+213 lines, -279 lines)			Patch
M	src/gpu/GrContext.cpp	View	2 chunks	+97 lines, -81 lines	0 comments	Download
M	src/gpu/GrGpu.h	View	4 chunks	+23 lines, -51 lines	0 comments	Download
M	src/gpu/GrGpu.cpp	View	1 chunk	+0 lines, -55 lines	0 comments	Download
M	src/gpu/GrTest.cpp	View	1 chunk	+7 lines, -8 lines	0 comments	Download
M	src/gpu/gl/GrGLGpu.h	View	1 chunk	+9 lines, -7 lines	0 comments	Download
M	src/gpu/gl/GrGLGpu.cpp	View	4 chunks	+56 lines, -56 lines	0 comments	Download
M	tests/WritePixelsTest.cpp	View	9 chunks	+21 lines, -21 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1260293004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1260293004/1

5 years, 4 months ago (2015-07-28 19:23:20 UTC) #2

commit-bot: I haz the power

5 years, 4 months ago (2015-07-28 19:23:30 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c3fb74693e25cf6dffc8add8669c54c4b7ace3a2

Expand Messages | Collapse Messages