runtime/vm/thread_registry.cc - Issue 1260283007: Fix race and limit access to mutator_thread_.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/thread_registry.cc

Issue 1260283007: Fix race and limit access to mutator_thread_. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Remove debug print. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/thread_registry.cc

diff --git a/runtime/vm/thread_registry.cc b/runtime/vm/thread_registry.cc

index 5d23ed69ba06c34da7d7ef79f131b3682c080983..8ade009c6035e6762ee9f45b39b1ce2dcc00100c 100644

--- a/runtime/vm/thread_registry.cc

+++ b/runtime/vm/thread_registry.cc

@@ -27,7 +27,7 @@ void ThreadRegistry::SafepointThreads() {

// TODO(koda): Rename Thread::PrepareForGC and call it here?

--remaining_; // Exclude this thread from the count.

// Ensure the main mutator will reach a safepoint (could be running Dart).

- if (Thread::Current() != isolate->mutator_thread()) {

+ if (!isolate->MutatorThreadIsCurrentThread()) {

isolate->ScheduleInterrupts(Isolate::kVMInterrupt);

}

while (remaining_ > 0) {

« no previous file with comments | « runtime/vm/thread.cc ('k') | no next file » | no next file with comments »