runtime/vm/dart_api_impl.cc - Issue 1260283007: Fix race and limit access to mutator_thread_.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 1260283007: Fix race and limit access to mutator_thread_. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Remove debug print. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/dart_api_impl.cc

diff --git a/runtime/vm/dart_api_impl.cc b/runtime/vm/dart_api_impl.cc

index 75a5954b613f54faf30d1a2cd8d821f004ce3a7a..038bfc85e64e7425fde0e191965309f23fc756ca 100644

--- a/runtime/vm/dart_api_impl.cc

+++ b/runtime/vm/dart_api_impl.cc

@@ -1442,7 +1442,7 @@ DART_EXPORT void Dart_EnterIsolate(Dart_Isolate isolate) {

CHECK_NO_ISOLATE(Isolate::Current());

// TODO(16615): Validate isolate parameter.

Isolate* iso = reinterpret_cast<Isolate*>(isolate);

- if (iso->mutator_thread() != NULL) {

+ if (iso->HasMutatorThread()) {

FATAL("Multiple mutators within one isolate is not supported.");

}

Thread::EnsureInit();

« no previous file with comments | « no previous file | runtime/vm/isolate.h » ('j') | no next file with comments »