Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1260273002: Optimize ToNumber and NonNumberToNumber. (Closed)

Created:
5 years, 4 months ago by bbudge
Modified:
5 years, 4 months ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Optimize ToNumber and NonNumberToNumber. Moves some uncommon type checking from ToNumber and NonNumberToNumber into DefaultNumber. This should speed up numeric operations especially as more "value types are added. LOG=N BUG=513196, v8:4124 Committed: https://crrev.com/e31da45e0fb2fc56c4f4351732ebfb32e0daf02a Cr-Commit-Position: refs/heads/master@{#29908}

Patch Set 1 #

Patch Set 2 : Rebase. #

Total comments: 2

Patch Set 3 : Add comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -16 lines) Patch
M src/runtime.js View 1 2 3 chunks +13 lines, -16 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
bbudge
This seems to give about 3% back.
5 years, 4 months ago (2015-07-28 14:59:12 UTC) #2
rossberg
lgtm https://codereview.chromium.org/1260273002/diff/20001/src/runtime.js File src/runtime.js (left): https://codereview.chromium.org/1260273002/diff/20001/src/runtime.js#oldcode796 src/runtime.js:796: if (IS_FLOAT32X4(x)) throw MakeTypeError(kSimdToNumber); Perhaps add a comment ...
5 years, 4 months ago (2015-07-28 15:03:19 UTC) #3
bbudge
https://codereview.chromium.org/1260273002/diff/20001/src/runtime.js File src/runtime.js (left): https://codereview.chromium.org/1260273002/diff/20001/src/runtime.js#oldcode796 src/runtime.js:796: if (IS_FLOAT32X4(x)) throw MakeTypeError(kSimdToNumber); On 2015/07/28 15:03:19, rossberg wrote: ...
5 years, 4 months ago (2015-07-28 15:09:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1260273002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1260273002/40001
5 years, 4 months ago (2015-07-28 15:14:10 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-07-30 08:16:14 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 08:16:26 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e31da45e0fb2fc56c4f4351732ebfb32e0daf02a
Cr-Commit-Position: refs/heads/master@{#29908}

Powered by Google App Engine
This is Rietveld 408576698