Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Unified Diff: components/password_manager/core/browser/password_manager_unittest.cc

Issue 1260263002: Move ShouldFilterAutofillResult from ChromePasswordManagerClient to PasswordManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: First version with sync layer, IsSyncCredential TODO still pending Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager_unittest.cc
diff --git a/components/password_manager/core/browser/password_manager_unittest.cc b/components/password_manager/core/browser/password_manager_unittest.cc
index 6f760d85a19c51954beafef8d13ec86efcec501f..41cbed0627890118777a66845887266b95bc5cee 100644
--- a/components/password_manager/core/browser/password_manager_unittest.cc
+++ b/components/password_manager/core/browser/password_manager_unittest.cc
@@ -7,6 +7,7 @@
#include <string>
#include <vector>
+#include "base/memory/scoped_ptr.h"
#include "base/message_loop/message_loop.h"
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
@@ -14,6 +15,7 @@
#include "components/password_manager/core/browser/password_autofill_manager.h"
#include "components/password_manager/core/browser/password_manager_driver.h"
#include "components/password_manager/core/browser/password_store.h"
+#include "components/password_manager/core/browser/store_result_filter.h"
#include "components/password_manager/core/browser/stub_password_manager_client.h"
#include "components/password_manager/core/browser/stub_password_manager_driver.h"
#include "components/password_manager/core/common/password_manager_pref_names.h"
@@ -32,6 +34,12 @@ namespace password_manager {
namespace {
+class TestStoreResultFilter : public StoreResultFilter {
+ bool ShouldIgnore(const autofill::PasswordForm& form) override {
+ return false;
+ };
+};
+
class MockPasswordManagerClient : public StubPasswordManagerClient {
public:
MOCK_CONST_METHOD0(IsSavingEnabledForCurrentPage, bool());
@@ -48,15 +56,18 @@ class MockPasswordManagerClient : public StubPasswordManagerClient {
MOCK_METHOD0(GetDriver, PasswordManagerDriver*());
// Workaround for scoped_ptr<> lacking a copy constructor.
- bool PromptUserToSavePassword(
- scoped_ptr<PasswordFormManager> manager,
- password_manager::CredentialSourceType type) override {
+ bool PromptUserToSavePassword(scoped_ptr<PasswordFormManager> manager,
+ CredentialSourceType type) override {
PromptUserToSavePasswordPtr(manager.release(), type);
return false;
}
void AutomaticPasswordSave(scoped_ptr<PasswordFormManager> manager) override {
AutomaticPasswordSaveIndicator();
}
+
+ scoped_ptr<StoreResultFilter> CreateStoreResultFilter() const override {
+ return make_scoped_ptr(new TestStoreResultFilter());
+ }
};
class MockPasswordManagerDriver : public StubPasswordManagerDriver {

Powered by Google App Engine
This is Rietveld 408576698