Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Unified Diff: components/password_manager/core/browser/stub_password_manager_client.cc

Issue 1260263002: Move ShouldFilterAutofillResult from ChromePasswordManagerClient to PasswordManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Just rebased Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/stub_password_manager_client.cc
diff --git a/components/password_manager/core/browser/stub_password_manager_client.cc b/components/password_manager/core/browser/stub_password_manager_client.cc
index d376e69e27b5369b4a4131b5d38dfe4a4e94930f..3f83c082f029c6b594a0315c8cf3c6b493a4b544 100644
--- a/components/password_manager/core/browser/stub_password_manager_client.cc
+++ b/components/password_manager/core/browser/stub_password_manager_client.cc
@@ -4,11 +4,25 @@
#include "components/password_manager/core/browser/stub_password_manager_client.h"
+#include "base/memory/scoped_ptr.h"
#include "base/memory/scoped_vector.h"
#include "components/password_manager/core/browser/password_form_manager.h"
+#include "components/password_manager/core/browser/store_result_filter.h"
namespace password_manager {
+namespace {
+
+// This filter does not filter out anything, it is a dummy implementation of
+// the filter interface.
+class PassThroughStoreResultFilter : public StoreResultFilter {
+ public:
+ bool ShouldIgnore(const autofill::PasswordForm& form) override {
+ return false;
+ }
+};
+}
+
StubPasswordManagerClient::StubPasswordManagerClient() {
}
@@ -25,11 +39,6 @@ bool StubPasswordManagerClient::IsSyncAccountCredential(
return false;
}
-bool StubPasswordManagerClient::ShouldFilterAutofillResult(
- const autofill::PasswordForm& form) {
- return false;
-}
-
bool StubPasswordManagerClient::PromptUserToSaveOrUpdatePassword(
scoped_ptr<PasswordFormManager> form_to_save,
password_manager::CredentialSourceType type,
@@ -61,4 +70,13 @@ PasswordStore* StubPasswordManagerClient::GetPasswordStore() const {
return nullptr;
}
+const GURL& StubPasswordManagerClient::GetLastCommittedEntryURL() const {
+ return GURL::EmptyGURL();
+}
+
+scoped_ptr<StoreResultFilter>
+StubPasswordManagerClient::CreateStoreResultFilter() const {
+ return make_scoped_ptr(new PassThroughStoreResultFilter);
+}
+
} // namespace password_manager

Powered by Google App Engine
This is Rietveld 408576698