Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Unified Diff: components/password_manager/core/browser/password_manager_client.h

Issue 1260263002: Move ShouldFilterAutofillResult from ChromePasswordManagerClient to PasswordManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Just rebased Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager_client.h
diff --git a/components/password_manager/core/browser/password_manager_client.h b/components/password_manager/core/browser/password_manager_client.h
index 7bee0a127879bf525aed6e74aa790cb21a3876f6..8adcb7069fcc4004c501173dc8b7c2a7f094d1e9 100644
--- a/components/password_manager/core/browser/password_manager_client.h
+++ b/components/password_manager/core/browser/password_manager_client.h
@@ -9,6 +9,7 @@
#include "base/memory/scoped_vector.h"
#include "components/autofill/core/common/password_form.h"
#include "components/password_manager/core/browser/password_store.h"
+#include "components/password_manager/core/browser/store_result_filter.h"
class PrefService;
@@ -59,10 +60,6 @@ class PasswordManagerClient {
// of SSL errors on a page.
virtual bool IsSavingEnabledForCurrentPage() const;
- // Return true if |form| should not be available for autofill.
- virtual bool ShouldFilterAutofillResult(
- const autofill::PasswordForm& form) = 0;
-
// Return the username that the user is syncing with. Should return an empty
// string if sync is not enabled for passwords.
virtual std::string GetSyncUsername() const = 0;
@@ -72,10 +69,6 @@ class PasswordManagerClient {
virtual bool IsSyncAccountCredential(const std::string& username,
const std::string& realm) const = 0;
- // Called when all autofill results have been computed. Client can use
- // this signal to report statistics. Default implementation is a noop.
- virtual void AutofillResultsComputed();
-
// Informs the embedder of a password form that can be saved or updated in
// password store if the user allows it. The embedder is not required to
// prompt the user if it decides that this form doesn't need to be saved or
@@ -175,6 +168,14 @@ class PasswordManagerClient {
// Returns true if the UI for confirmation of update password is enabled.
virtual bool IsUpdatePasswordUIEnabled() const;
+ virtual const GURL& GetLastCommittedEntryURL() const = 0;
+
+ // Creates a filter for PasswordFormManager to process password store
+ // response. One filter should be created for every batch of store results for
+ // a single observed form. The filter results should not be cached.
+ virtual scoped_ptr<password_manager::StoreResultFilter>
+ CreateStoreResultFilter() const = 0;
+
private:
DISALLOW_COPY_AND_ASSIGN(PasswordManagerClient);
};

Powered by Google App Engine
This is Rietveld 408576698