components/password_manager/core/browser/password_form_manager.h - Issue 1260263002: Move ShouldFilterAutofillResult from ChromePasswordManagerClient to PasswordManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_form_manager.h

Issue 1260263002: Move ShouldFilterAutofillResult from ChromePasswordManagerClient to PasswordManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Just rebased Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/BUILD.gn ('k') | components/password_manager/core/browser/password_form_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_form_manager.h

diff --git a/components/password_manager/core/browser/password_form_manager.h b/components/password_manager/core/browser/password_form_manager.h

index 20255ee66a1c7f4a1f53bf63eb59f2f94a7e3d8b..f968af0f59988296a01ae757dce23e160db73052 100644

--- a/components/password_manager/core/browser/password_form_manager.h

+++ b/components/password_manager/core/browser/password_form_manager.h

@@ -22,6 +22,7 @@ namespace password_manager {

class PasswordManager;

class PasswordManagerClient;

+class StoreResultFilter;

// Per-password-form-{on-page, dialog} class responsible for interactions

// between a given form, the per-tab PasswordManager, and the PasswordStore.

@@ -287,7 +288,8 @@ class PasswordFormManager : public PasswordStoreConsumer {

// Helper for OnGetPasswordStoreResults to determine whether or not

// the given result form is worth scoring.

- bool ShouldIgnoreResult(const autofill::PasswordForm& form) const;

+ bool ShouldIgnoreResult(const autofill::PasswordForm& form,

+ StoreResultFilter* filter) const;

// Helper for Save in the case that best_matches.size() == 0, meaning

// we have no prior record of this form/username/password and the user