components/password_manager/README - Issue 1260263002: Move ShouldFilterAutofillResult from ChromePasswordManagerClient to PasswordManager

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/password_manager/README

Issue 1260263002: Move ShouldFilterAutofillResult from ChromePasswordManagerClient to PasswordManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First version with sync layer, IsSyncCredential TODO still pending Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 PasswordManager is in the process of becoming a layered component	1 Ideal structure of the component:

2 (https://sites.google.com/a/chromium.org/dev/developers/design-documents/layered -components-design)	2 - core/: Essentials, not depending on any other layers.
engedy 2015/08/04 10:11:28 nit: We could keep the URL. nit: We could keep the URL. vabr (Chromium) 2015/08/04 12:21:25 Done. Show quoted text On 2015/08/04 10:11:28, engedy wrote: > nit: We could keep the URL. Done.
3 to enable it to be shared cleanly on iOS.	3 All other layers may depend on core:

4	4 - content/: Content-specific embedding.

5 When this process is complete, this component will have the following structure:	5 - sync/: Sync-specific embedding.

6

7 - core/: shared code that does not depend on src/content/ or src/ios/

8 - content/: Driver for the shared code based on the content layer.

9 - ios/: Driver for the shared code based on src/ios.

OLD	NEW

« no previous file with comments | « components/password_manager.gypi ('k') | components/password_manager/content/DEPS » ('j') | no next file with comments »